chore(algebra/category/CommRing/limits): fix typo, remove private #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcommelin
reviewed
Oct 22, 2019
Co-Authored-By: Johan Commelin <johan@commelin.net>
semorrison
commented
Oct 22, 2019
semorrison
commented
Oct 22, 2019
|
Actually, @jcommelin, changed my mind --- these functions are really "private", and not meant to be used once we've set up the limit, so I'd prefer to keep them in an obscure namespace. I've added comments making this explicit. |
semorrison
commented
Oct 22, 2019
|
Ok, fair enough. |
jcommelin
added
the
ready-to-merge
jcommelin
approved these changes
Oct 22, 2019
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…anprover-community#1584) * chore(algebra/category/CommRing/limits): fix typo, remove private * Update src/algebra/category/CommRing/limits.lean Co-Authored-By: Johan Commelin <johan@commelin.net> * Update src/algebra/category/CommRing/limits.lean * Update src/algebra/category/CommRing/limits.lean * bleh * Update src/algebra/category/CommRing/limits.lean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely trivial; fixes a typo in a comment, and removes two
privateannotations in favour of putting the definitions in an appropriate namespace.