doc(data/fin): add docs; fin_zero_elim -> fin.elim0; fin_zero_elim' -> fin_zero_elim #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also drom `fin_zero_elim` in favor of `fin.elim0` from `stdlib` and rename `fin_zero_elim'` to `fin_zero_elim`.
robertylewis
changed the title
src/data/fin.lean
Outdated
| | 0 i := i.elim0 | ||
| | (succ n) ⟨0, _⟩ := H0 _ | ||
| | (succ n) ⟨succ i, h⟩ := Hs _ _ (succ_rec ⟨i, lt_of_succ_lt_succ h⟩) | ||
|
|
||
| /-- Define `C n i` by induction on `i : fin n` interpreted as `(0 : fin (n - i)).succ.succ…`, |
There was a problem hiding this comment.
This is a little confusing. For one, Hs isn't introduced in the doc string. It's not immediately clear what the ... is doing. Instead of the short one-line description, could you maybe expand it to a few sentences that make it clearer how to use the definition?
There was a problem hiding this comment.
Reformulated. Is it better?
Co-Authored-By: Rob Lewis <Rob.y.lewis@gmail.com>
urkud
added
the
awaiting-author
urkud
added
awaiting-review
robertylewis
approved these changes
Mar 2, 2020
robertylewis
added
ready-to-merge
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…> fin_zero_elim (leanprover-community#2055) * doc(data/fin): add some docs Also drom `fin_zero_elim` in favor of `fin.elim0` from `stdlib` and rename `fin_zero_elim'` to `fin_zero_elim`. * Update src/data/fin.lean Co-Authored-By: Rob Lewis <Rob.y.lewis@gmail.com> * Update docs, fix `Π` vs `∀`. Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…> fin_zero_elim (leanprover-community#2055) * doc(data/fin): add some docs Also drom `fin_zero_elim` in favor of `fin.elim0` from `stdlib` and rename `fin_zero_elim'` to `fin_zero_elim`. * Update src/data/fin.lean Co-Authored-By: Rob Lewis <Rob.y.lewis@gmail.com> * Update docs, fix `Π` vs `∀`. Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also drom
fin_zero_elimin favor offin.elim0fromstdlibandrename
fin_zero_elim'tofin_zero_elim.Are there any theorems in
data/finworth mentioning in the module docstring?TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list