Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a noncomm_ring tactic #2727

Closed
semorrison opened this issue May 18, 2020 · 1 comment
Closed

a noncomm_ring tactic #2727

semorrison opened this issue May 18, 2020 · 1 comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. feature-request This issue is a feature request, either for mathematics, tactics, or CI help-wanted The author needs attention to resolve issues t-meta Tactics, attributes or user commands

Comments

@semorrison
Copy link
Collaborator

From tactics for noncommutative rings on zulip:

meta def noncomm_ring := 
`[simp only [add_mul, mul_add, sub_eq_add_neg, 
    neg_mul_eq_neg_mul_symm, mul_neg_eq_neg_mul_symm, mul_assoc], 
  abel]

A PR would need to add a doc string, and some test cases.
@semorrison semorrison added easy < 20s of review time. See the lifecycle page for guidelines. feature-request This issue is a feature request, either for mathematics, tactics, or CI help-wanted The author needs attention to resolve issues t-meta Tactics, attributes or user commands labels May 18, 2020
@digama0
Copy link
Member

digama0 commented May 18, 2020

also that needs a semicolon instead of a comma in case the simp closes the goal.

ocfnash pushed a commit that referenced this issue May 29, 2020
feat(tactic/noncomm_ring): add noncomm_ring tactic
ffd1ef0 
Fixes #2727
@ocfnash ocfnash mentioned this issue May 29, 2020
Closed
@bors bors bot closed this as completed in 0827a30 May 31, 2020
cipher1024 pushed a commit to cipher1024/mathlib that referenced this issue Mar 15, 2022
@semorrison @cipher1024
feat(tactic/noncomm_ring): add noncomm_ring tactic (leanprover-commun…
2544a90 
…ity#2858)

Fixes leanprover-community#2727

Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. feature-request This issue is a feature request, either for mathematics, tactics, or CI help-wanted The author needs attention to resolve issues t-meta Tactics, attributes or user commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - feat(tactic/noncomm_ring): add noncomm_ring tactic leanprover-community/mathlib
2 participants
@semorrison @digama0