[Merged by Bors] - chore(category_theory): T50000 challenge #2840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
bryangingechen
added
the
awaiting-review
bors bot
pushed a commit
that referenced
this pull request
May 27, 2020
This PR adds `-T100000` to CI. This is the default timeout setting in the VS Code extension and emacs. With some exceptions, noted with `FIXME` comments mentioning `-T50000`, the library now compiles with `-T50000`: - [ ] `has_sum.has_sum_ne_zero` in `src/topology/algebra/infinite_sum.lean`, where I don't really understand why it is slow. - [ ] `exists_norm_eq_infi_of_complete_convex` in `src/analysis/normed_space/real_inner_product.lean`, which has a giant proof which should be rewritten in several steps. - [ ] `tangent_bundle_core.coord_change_comp` in `src/geometry/manifold/basic_smooth_bundle.lean`. - [ ] `change_origin_radius` in `src/analysis/analytic/basic.lean` There are 3 `def`s related to category theory which also don't compile: - [ ] `adj₁` in `src/topology/category/Top/adjunctions.lean` - [x] `cones_equiv_inverse` in `src/category_theory/limits/over.lean` (addressed in #2840) - [ ] `prod_functor` in `src/category_theory/limits/shapes/binary_products.lean` This proof no longer causes problems with `-T50000`, but it should still be broken up at some point. - [ ] `simple_func_sequence_tendsto` in `src/measure_theory/simple_func_dense.lean`, which has a giant proof which should be rewritten in several steps. ~~This one is really bad, and doesn't even compile with `-T100000`.~~ [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/-T50000.20challenge). Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
b-mehta
approved these changes
May 28, 2020
semorrison
commented
May 29, 2020
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
May 29, 2020
A lame effort at making something compile with `-T50000`. No actual speed improvement, just split up a definition into pieces. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
…2276) This PR adds `-T100000` to CI. This is the default timeout setting in the VS Code extension and emacs. With some exceptions, noted with `FIXME` comments mentioning `-T50000`, the library now compiles with `-T50000`: - [ ] `has_sum.has_sum_ne_zero` in `src/topology/algebra/infinite_sum.lean`, where I don't really understand why it is slow. - [ ] `exists_norm_eq_infi_of_complete_convex` in `src/analysis/normed_space/real_inner_product.lean`, which has a giant proof which should be rewritten in several steps. - [ ] `tangent_bundle_core.coord_change_comp` in `src/geometry/manifold/basic_smooth_bundle.lean`. - [ ] `change_origin_radius` in `src/analysis/analytic/basic.lean` There are 3 `def`s related to category theory which also don't compile: - [ ] `adj₁` in `src/topology/category/Top/adjunctions.lean` - [x] `cones_equiv_inverse` in `src/category_theory/limits/over.lean` (addressed in leanprover-community#2840) - [ ] `prod_functor` in `src/category_theory/limits/shapes/binary_products.lean` This proof no longer causes problems with `-T50000`, but it should still be broken up at some point. - [ ] `simple_func_sequence_tendsto` in `src/measure_theory/simple_func_dense.lean`, which has a giant proof which should be rewritten in several steps. ~~This one is really bad, and doesn't even compile with `-T100000`.~~ [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/-T50000.20challenge). Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
A lame effort at making something compile with `-T50000`. No actual speed improvement, just split up a definition into pieces. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lame effort at making something compile with
-T50000. No actual speed improvement, just split up a definition into pieces.