[Merged by Bors] - feat(CI): add -T100000 to the build step in CI #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
not-ready-to-merge
CI
added 2 commits
April 8, 2020 20:48
semorrison
changed the title
semorrison
commented
Apr 11, 2020
|
Fixed. Actually, I should move those changes to a separate PR, in any case. |
semorrison
added
the
blocked-by-other-PR
|
Now blocked on #2393, which contains the fixes to two theorems that I'd previously pushed here. |
bors bot
pushed a commit
that referenced
this pull request
Apr 14, 2020
Refactor two proofs to bring them under `-T50000`, in the hope that we can later add this requirement to CI, per #2276.
|
Now it fails in |
|
Yes, |
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
Refactor two proofs to bring them under `-T50000`, in the hope that we can later add this requirement to CI, per leanprover-community#2276.
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
Refactor two proofs to bring them under `-T50000`, in the hope that we can later add this requirement to CI, per leanprover-community#2276.
|
Wow, mathlib builds with 100000 again, I guess because of the changes in Lean 3.13. I've changed it to 50000 again (and disabled finding the olean cache to make the build more honest) to see what happens. |
|
I think that we should add |
|
Agreed. I'll see if I can mark the new T50000 failures with FIXME. |
bryangingechen
added
the
awaiting-review
|
bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
May 27, 2020
This PR adds `-T100000` to CI. This is the default timeout setting in the VS Code extension and emacs. With some exceptions, noted with `FIXME` comments mentioning `-T50000`, the library now compiles with `-T50000`: - [ ] `has_sum.has_sum_ne_zero` in `src/topology/algebra/infinite_sum.lean`, where I don't really understand why it is slow. - [ ] `exists_norm_eq_infi_of_complete_convex` in `src/analysis/normed_space/real_inner_product.lean`, which has a giant proof which should be rewritten in several steps. - [ ] `tangent_bundle_core.coord_change_comp` in `src/geometry/manifold/basic_smooth_bundle.lean`. - [ ] `change_origin_radius` in `src/analysis/analytic/basic.lean` There are 3 `def`s related to category theory which also don't compile: - [ ] `adj₁` in `src/topology/category/Top/adjunctions.lean` - [x] `cones_equiv_inverse` in `src/category_theory/limits/over.lean` (addressed in #2840) - [ ] `prod_functor` in `src/category_theory/limits/shapes/binary_products.lean` This proof no longer causes problems with `-T50000`, but it should still be broken up at some point. - [ ] `simple_func_sequence_tendsto` in `src/measure_theory/simple_func_dense.lean`, which has a giant proof which should be rewritten in several steps. ~~This one is really bad, and doesn't even compile with `-T100000`.~~ [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/-T50000.20challenge). Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Jun 10, 2020
cf. #2276. This will also prevent some confusing timeouts, see e.g. https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Tests.20fail
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
Refactor two proofs to bring them under `-T50000`, in the hope that we can later add this requirement to CI, per leanprover-community#2276.
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
…2276) This PR adds `-T100000` to CI. This is the default timeout setting in the VS Code extension and emacs. With some exceptions, noted with `FIXME` comments mentioning `-T50000`, the library now compiles with `-T50000`: - [ ] `has_sum.has_sum_ne_zero` in `src/topology/algebra/infinite_sum.lean`, where I don't really understand why it is slow. - [ ] `exists_norm_eq_infi_of_complete_convex` in `src/analysis/normed_space/real_inner_product.lean`, which has a giant proof which should be rewritten in several steps. - [ ] `tangent_bundle_core.coord_change_comp` in `src/geometry/manifold/basic_smooth_bundle.lean`. - [ ] `change_origin_radius` in `src/analysis/analytic/basic.lean` There are 3 `def`s related to category theory which also don't compile: - [ ] `adj₁` in `src/topology/category/Top/adjunctions.lean` - [x] `cones_equiv_inverse` in `src/category_theory/limits/over.lean` (addressed in leanprover-community#2840) - [ ] `prod_functor` in `src/category_theory/limits/shapes/binary_products.lean` This proof no longer causes problems with `-T50000`, but it should still be broken up at some point. - [ ] `simple_func_sequence_tendsto` in `src/measure_theory/simple_func_dense.lean`, which has a giant proof which should be rewritten in several steps. ~~This one is really bad, and doesn't even compile with `-T100000`.~~ [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/-T50000.20challenge). Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
cf. leanprover-community#2276. This will also prevent some confusing timeouts, see e.g. https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Tests.20fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
-T100000to CI. This is the default timeout setting in the VS Code extension and emacs.With some exceptions, noted with
FIXMEcomments mentioning-T50000, the library now compiles with-T50000:has_sum.has_sum_ne_zeroinsrc/topology/algebra/infinite_sum.lean, where I don't really understand why it is slow.exists_norm_eq_infi_of_complete_convexinsrc/analysis/normed_space/real_inner_product.lean, which has a giant proof which should be rewritten in several steps.tangent_bundle_core.coord_change_compinsrc/geometry/manifold/basic_smooth_bundle.lean.change_origin_radiusinsrc/analysis/analytic/basic.leanThere are 3
defs related to category theory which also don't compile:adj₁insrc/topology/category/Top/adjunctions.leancones_equiv_inverseinsrc/category_theory/limits/over.lean(addressed in [Merged by Bors] - chore(category_theory): T50000 challenge #2840)prod_functorinsrc/category_theory/limits/shapes/binary_products.leanThis proof no longer causes problems with
-T50000, but it should still be broken up at some point.simple_func_sequence_tendstoinsrc/measure_theory/simple_func_dense.lean, which has a giant proof which should be rewritten in several steps.This one is really bad, and doesn't even compile with-T100000.Zulip thread.