[Merged by Bors] - chore(data/polynomial): partial move from is_ring_hom to ring_hom #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
semorrison
added
the
blocked-by-other-PR
semorrison
changed the title
semorrison
changed the title
jcommelin
removed
the
blocked-by-other-PR
jcommelin
changed the title
|
12 conflicts |
bryangingechen
added
the
awaiting-author
|
Hopefully the conflicts have been resolved successfully. We'll see if it builds! |
semorrison
added
awaiting-review
jcommelin
reviewed
Jun 30, 2020
| @@ -129,7 +129,12 @@ local attribute [instance] coeff_coe_to_fun | |||
| def monomial (s : σ →₀ ℕ) (a : α) : mv_polynomial σ α := single s a | |||
|
|
|||
| /-- `C a` is the constant polynomial with value `a` -/ | |||
| def C (a : α) : mv_polynomial σ α := monomial 0 a | |||
| def C : α →+* mv_polynomial σ α := | |||
There was a problem hiding this comment.
How about making monomial and add_monoid_hom first?
There was a problem hiding this comment.
Yes, I agree.
Could I ask though that I defer making significant further changes for a later PR? I definitely want to change a lot more in polynomial.lean and mv_polynomial.lean, but the cayley_hamilton branch can go in for review once this PR is merged, and if we wait for a thorough refactor of polynomials it will start rotting. :-)
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 30, 2020
) This does not attempt to do a complete refactor of `polynomial.lean` and `mv_polynomial.lean` to remove use of `is_ring_hom`, but only to fix `eval₂` which we need for the current work on Cayley-Hamilton. Having struggled with these two files for the last few days, I'm keen to get them cleaned up, so I'll promise to return to this more thoroughly in a later PR. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Alex J. Best <alex.j.best@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
…anprover-community#3213) This does not attempt to do a complete refactor of `polynomial.lean` and `mv_polynomial.lean` to remove use of `is_ring_hom`, but only to fix `eval₂` which we need for the current work on Cayley-Hamilton. Having struggled with these two files for the last few days, I'm keen to get them cleaned up, so I'll promise to return to this more thoroughly in a later PR. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Alex J. Best <alex.j.best@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not attempt to do a complete refactor of
polynomial.leanandmv_polynomial.leanto remove use ofis_ring_hom, but only to fixeval₂which we need for the current work on Cayley-Hamilton.Having struggled with these two files for the last few days, I'm keen to get them cleaned up, so I'll promise to return to this more thoroughly in a later PR.
Blocked by #3193.