-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(data/polynomial): partial move from is_ring_hom to ring_hom #3213
Conversation
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
12 conflicts |
Hopefully the conflicts have been resolved successfully. We'll see if it builds! |
@@ -129,7 +129,12 @@ local attribute [instance] coeff_coe_to_fun | |||
def monomial (s : σ →₀ ℕ) (a : α) : mv_polynomial σ α := single s a | |||
|
|||
/-- `C a` is the constant polynomial with value `a` -/ | |||
def C (a : α) : mv_polynomial σ α := monomial 0 a | |||
def C : α →+* mv_polynomial σ α := |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about making monomial
and add_monoid_hom
first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree.
Could I ask though that I defer making significant further changes for a later PR? I definitely want to change a lot more in polynomial.lean
and mv_polynomial.lean
, but the cayley_hamilton
branch can go in for review once this PR is merged, and if we wait for a thorough refactor of polynomials it will start rotting. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!
Thanks 🎉 bors merge |
) This does not attempt to do a complete refactor of `polynomial.lean` and `mv_polynomial.lean` to remove use of `is_ring_hom`, but only to fix `eval₂` which we need for the current work on Cayley-Hamilton. Having struggled with these two files for the last few days, I'm keen to get them cleaned up, so I'll promise to return to this more thoroughly in a later PR. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Alex J. Best <alex.j.best@gmail.com>
Pull request successfully merged into master. Build succeeded: |
…anprover-community#3213) This does not attempt to do a complete refactor of `polynomial.lean` and `mv_polynomial.lean` to remove use of `is_ring_hom`, but only to fix `eval₂` which we need for the current work on Cayley-Hamilton. Having struggled with these two files for the last few days, I'm keen to get them cleaned up, so I'll promise to return to this more thoroughly in a later PR. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Alex J. Best <alex.j.best@gmail.com>
This does not attempt to do a complete refactor of
polynomial.lean
andmv_polynomial.lean
to remove use ofis_ring_hom
, but only to fixeval₂
which we need for the current work on Cayley-Hamilton.Having struggled with these two files for the last few days, I'm keen to get them cleaned up, so I'll promise to return to this more thoroughly in a later PR.
Blocked by #3193.