[Merged by Bors] - refactor(data/polynomial): re-organizing #3512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some independent material now compiles separately, but the import graph is still fairly linear. |
|
(moved to first post) |
bryangingechen
added
the
awaiting-review
|
I haven't looked carefully at the changes, but the description sounds fine to me. |
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 22, 2020
This builds on #3407, trying to get related material closer together. There shouldn't be any change to the set of declarations, just the order they come in and the imports required to get them. The major changes are: 1. `data.polynomial.derivative` now has much weaker imports 2. generally, material has been moved "upwards" to the first place it can be done (a lot of material moved out of `data.polynomial.degree` into `data.polynomial.degree.basic` -- essentially `degree` is the material about `degree` that also needs `eval` and friends; a further rename might be appropriate) 3. some of the later material is no longer a big chain of linear dependencies, but compiles separately Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 22, 2020
This builds on #3407, trying to get related material closer together. There shouldn't be any change to the set of declarations, just the order they come in and the imports required to get them. The major changes are: 1. `data.polynomial.derivative` now has much weaker imports 2. generally, material has been moved "upwards" to the first place it can be done (a lot of material moved out of `data.polynomial.degree` into `data.polynomial.degree.basic` -- essentially `degree` is the material about `degree` that also needs `eval` and friends; a further rename might be appropriate) 3. some of the later material is no longer a big chain of linear dependencies, but compiles separately Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com> Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #3407, trying to get related material closer together.
There shouldn't be any change to the set of declarations, just the order they come in and the imports required to get them.
The major changes are:
data.polynomial.derivativenow has much weaker importsdata.polynomial.degreeintodata.polynomial.degree.basic-- essentiallydegreeis the material aboutdegreethat also needsevaland friends; a further rename might be appropriate)