This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(data/polynomial): break up behemoth file #3407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalex-stark
commented
Jul 15, 2020
jalex-stark
commented
Jul 15, 2020
jalex-stark
commented
Jul 15, 2020
jalex-stark
changed the title
…ommunity/mathlib into polynomial_refactor
…ommunity/mathlib into polynomial_refactor
…ommunity/mathlib into polynomial_refactor
…ommunity/mathlib into polynomial_refactor
…ommunity/mathlib into polynomial_refactor
jalex-stark
added
awaiting-review
kim-em
reviewed
Jul 16, 2020
kim-em
reviewed
Jul 16, 2020
jcommelin
approved these changes
Jul 16, 2020
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 16, 2020
Polynomial refactor The goal is to split `data/polynomial.lean` into several self-contained files in the same place. For the time being, the new place for all these files is `data/polynomial/`. Future PRs may simplify proofs, remove duplicate lemmas, and move files out of the `data` directory. Co-authored-by: Aaron Anderson <awainverse@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Jul 22, 2020
This builds on #3407, trying to get related material closer together. There shouldn't be any change to the set of declarations, just the order they come in and the imports required to get them. The major changes are: 1. `data.polynomial.derivative` now has much weaker imports 2. generally, material has been moved "upwards" to the first place it can be done (a lot of material moved out of `data.polynomial.degree` into `data.polynomial.degree.basic` -- essentially `degree` is the material about `degree` that also needs `eval` and friends; a further rename might be appropriate) 3. some of the later material is no longer a big chain of linear dependencies, but compiles separately Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
bors bot
pushed a commit
that referenced
this pull request
Jul 22, 2020
This builds on #3407, trying to get related material closer together. There shouldn't be any change to the set of declarations, just the order they come in and the imports required to get them. The major changes are: 1. `data.polynomial.derivative` now has much weaker imports 2. generally, material has been moved "upwards" to the first place it can be done (a lot of material moved out of `data.polynomial.degree` into `data.polynomial.degree.basic` -- essentially `degree` is the material about `degree` that also needs `eval` and friends; a further rename might be appropriate) 3. some of the later material is no longer a big chain of linear dependencies, but compiles separately Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com> Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polynomial refactor
The goal is to split
data/polynomial.leaninto several self-contained files in the same place. For the time being, the new place for all these files isdata/polynomial/.Future PRs may simplify proofs, remove duplicate lemmas, and move files out of the
datadirectory.Things to consider before merging
We split the contents of data/polynomial across 14 files. Some of them may want to be renamed and/or remixed, but unless there are any really obvious moves, I think we can defer that to future work.
All of them would be happy to have more detailed docstrings.
Does this PR make it easier or harder to find the lemmas? (as the author, I'm not sure)
Does this PR make the polynomial library easier to maintain? (my opinion is yes, definitely)
It will be mildly painful if this PR sits long enough for data/polynomial.lean to move ahead in master.