[Merged by Bors] - feat(measure_theory): image of Lebesgue measure under shift/rescale #3760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add lemmas `preimage_mul_const_Ixx` and `preimage_const_mul_Ixx`. Other changes: * `to_units` doesn't work with `to_additive`, so move the `to_fun` part to `units.mk'`. * Generalize `equiv.mul_left` and `equiv.mul_right` to `units`.
urkud
added
blocked-by-other-PR
github-actions
bot
added
the
merge-conflict
bryangingechen
removed
the
blocked-by-other-PR
github-actions
bot
removed
the
merge-conflict
github-actions
bot
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
urkud
added
awaiting-review
fpvandoorn
reviewed
Aug 22, 2020
There was a problem hiding this comment.
This is great! You have some ext lemmas that were nicer than mine, but I generalized the last special case a bit, without giving up (much) usability.
Note: not all lemmas about =ᵐ consistently use ae_eq, some use eventually_eq (this can be fixed in a different PR).
| @@ -1049,7 +1233,13 @@ class probability_measure (μ : measure α) : Prop := (measure_univ : μ univ = | |||
| /-- A measure `μ` is called finite if `μ univ < ⊤`. -/ | |||
| class finite_measure (μ : measure α) : Prop := (measure_univ_lt_top : μ univ < ⊤) | |||
|
|
|||
| export probability_measure (measure_univ) | |||
| /-- Measure `μ` *has no atoms* if the measure of each singleton is zero.-/ | |||
| class no_atoms_measure (μ : measure α) : Prop := | |||
There was a problem hiding this comment.
I think I would prefer the name has_no_atoms instead.
There was a problem hiding this comment.
I've also seen the term continuous measure for this property. The doc-string should mention this term.
There was a problem hiding this comment.
Renamed. Feel free to add "continuous measure" to the doc string. I don't want to do it myself because I never saw it (only "absolutely continuous" but this is a different property). I also commented on the definition. I don't want to change it in this PR but probably we should do it in the future.
fpvandoorn
added
awaiting-author
github-actions
bot
added
the
merge-conflict
Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
github-actions
bot
removed
the
merge-conflict
|
What is the status of this PR? Are you still working on the review comments? |
|
I'm sorry for the delay. I'll push update in about 1 hour. |
urkud
added
awaiting-review
github-actions
bot
added
the
merge-conflict
github-actions
bot
added
merge-conflict
github-actions
bot
removed
the
merge-conflict
|
Thanks for the fixes. bors r+ |
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
#3757#3758#3759