Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(metric_space): add lipschitz_on_with #4151

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat(metric_space): add lipschitz_on_with #4151

wants to merge 8 commits into from

Conversation

PatrickMassot
Copy link
Member

@PatrickMassot PatrickMassot commented Sep 14, 2020 •
edited by jcommelin

The order of the explicit arguments in this definition is open for negotiation.

From the sphere eversion project.

@PatrickMassot PatrickMassot added the awaiting-review The author would like community review of the PR label Sep 14, 2020
sgouezel
sgouezel reviewed Sep 14, 2020
View reviewed changes
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you don't need to copy the whole lipschitz API yet, but at least including lipschitz_on.continuous_on and lipschitz_on_univ (saying that lipschitz_on univ is the same as lipschitz) seems necessary. Also add a line on this in the file docstring.

src/analysis/normed_space/basic.lean Outdated Show resolved Hide resolved
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 14, 2020
@PatrickMassot
Copy link
Member Author

I proved your minimal API lemmas, filling a couple of weird holes on the way. But writing this makes me wonder whether I should switch the argument order between the function and the set. It sounded more natural to me that way, but it's opposite to the continuous_on order.

@PatrickMassot PatrickMassot added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 14, 2020
@sgouezel
Copy link
Collaborator

Can you change the order of variables to match that of continuous_on and uniform_continuous_on? Otherwise, looks good to me.

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 15, 2020
@PatrickMassot PatrickMassot added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 15, 2020
jcommelin
jcommelin approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 16, 2020
bors bot pushed a commit that referenced this pull request Sep 16, 2020
@PatrickMassot @urkud
feat(metric_space): add lipschitz_on_with (#4151)
9a11efb 
The order of the explicit arguments in this definition is open for negotiation.

From the sphere eversion project.



Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@bors
Copy link

bors bot commented Sep 16, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(metric_space): add lipschitz_on_with [Merged by Bors] - feat(metric_space): add lipschitz_on_with Sep 16, 2020
@bors bors bot closed this Sep 16, 2020
@bors bors bot deleted the lipon branch September 16, 2020 09:20
@YaelDillies YaelDillies removed the awaiting-review The author would like community review of the PR label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

@sgouezel sgouezel sgouezel left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PatrickMassot @sgouezel @urkud @jcommelin @YaelDillies