-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(field_theory): intermediate fields #4181
Conversation
692d769
to
612eb0c
Compare
612eb0c
to
8baee2b
Compare
Define `intermediate_field K L` as a structure extending `subalgebra K L` and `subfield L`. Requires re-bundling `subalgebra`, which will be another PR.
8baee2b
to
50a3771
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks super clean to me, but I'm no expert on the topic. Anyone we should flag to take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
Define `intermediate_field K L` as a structure extending `subalgebra K L` and `subfield L`. This definition required some changes in `subalgebra`, which I added in #4180. Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com>
Build failed (retrying...): |
build failure seems to be a github actions hiccup, going to try to add this to the upcoming batch manually |
Canceled. |
bors r+ |
Define `intermediate_field K L` as a structure extending `subalgebra K L` and `subfield L`. This definition required some changes in `subalgebra`, which I added in #4180. Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com>
This PR was included in a batch that was canceled, it will be automatically retried |
Define `intermediate_field K L` as a structure extending `subalgebra K L` and `subfield L`. This definition required some changes in `subalgebra`, which I added in #4180. Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
Define
intermediate_field K L
as a structure extendingsubalgebra K L
andsubfield L
.This definition required some changes in
subalgebra
, which I added in #4180.