Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(field_theory): intermediate fields #4181

Closed
wants to merge 2 commits into from

Conversation

Vierkantor
Copy link
Collaborator

Define intermediate_field K L as a structure extending subalgebra K L and subfield L.

This definition required some changes in subalgebra, which I added in #4180.


@Vierkantor Vierkantor added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. awaiting-review The author would like community review of the PR labels Sep 18, 2020
@Vierkantor Vierkantor force-pushed the intermediate_field branch 3 times, most recently from 692d769 to 612eb0c Compare September 22, 2020 10:46
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 22, 2020
@Vierkantor Vierkantor removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Sep 22, 2020
Define `intermediate_field K L` as a structure extending `subalgebra K L`
and `subfield L`. Requires re-bundling `subalgebra`, which will be another PR.
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 22, 2020
@Vierkantor Vierkantor changed the title feat(field_theory): intermediate fields (deps: #4180) feat(field_theory): intermediate fields Sep 23, 2020
Copy link
Member

@robertylewis robertylewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks super clean to me, but I'm no expert on the topic. Anyone we should flag to take a look?

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 24, 2020
bors bot pushed a commit that referenced this pull request Sep 24, 2020
Define `intermediate_field K L` as a structure extending `subalgebra K L` and `subfield L`.

This definition required some changes in `subalgebra`, which I added in #4180.



Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com>
@bors
Copy link

bors bot commented Sep 24, 2020

Build failed (retrying...):

@bryangingechen
Copy link
Collaborator

build failure seems to be a github actions hiccup, going to try to add this to the upcoming batch manually
bors r-

@bors
Copy link

bors bot commented Sep 24, 2020

Canceled.

@bryangingechen
Copy link
Collaborator

bors r+

@github-actions github-actions bot removed the awaiting-review The author would like community review of the PR label Sep 24, 2020
bors bot pushed a commit that referenced this pull request Sep 24, 2020
Define `intermediate_field K L` as a structure extending `subalgebra K L` and `subfield L`.

This definition required some changes in `subalgebra`, which I added in #4180.



Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com>
@bors
Copy link

bors bot commented Sep 24, 2020

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request Sep 24, 2020
Define `intermediate_field K L` as a structure extending `subalgebra K L` and `subfield L`.

This definition required some changes in `subalgebra`, which I added in #4180.



Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com>
@bors
Copy link

bors bot commented Sep 24, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(field_theory): intermediate fields [Merged by Bors] - feat(field_theory): intermediate fields Sep 24, 2020
@bors bors bot closed this Sep 24, 2020
@bors bors bot deleted the intermediate_field branch September 24, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants