[Merged by Bors] - refactor(ring_theory/algebra): re-bundle subalgebra
#4180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes `subalgebra` extend `subsemiring` instead of using `subsemiring` as a field in its definition. The refactor is needed because `intermediate_field` should simultaneously extend `subalgebra` and `subfield`, and so the type of the `carrier` fields should match. I added some copies of definitions that use `subring` instead of `is_subring` if I needed to change these definitions anyway.
Vierkantor
added
the
awaiting-review
|
✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with |
fpvandoorn
added
delegated
…s_subring` Co-Authored-By: Floris van Doorn <fpvdoorn@gmail.com>
|
bors merge |
github-actions
bot
added
the
ready-to-merge
|
Canceled. |
|
Let's try that again: bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 22, 2020
This PR makes `subalgebra` extend `subsemiring` instead of using `subsemiring` as a field in its definition. The refactor is needed because `intermediate_field` should simultaneously extend `subalgebra` and `subfield`, and so the type of the `carrier` fields should match. I added some copies of definitions that use `subring` instead of `is_subring` if I needed to change these definitions anyway.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
subalgebrasubalgebra
bors bot
pushed a commit
that referenced
this pull request
Sep 24, 2020
Define `intermediate_field K L` as a structure extending `subalgebra K L` and `subfield L`. This definition required some changes in `subalgebra`, which I added in #4180. Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com>
bors bot
pushed a commit
that referenced
this pull request
Sep 24, 2020
Define `intermediate_field K L` as a structure extending `subalgebra K L` and `subfield L`. This definition required some changes in `subalgebra`, which I added in #4180. Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com>
bors bot
pushed a commit
that referenced
this pull request
Sep 24, 2020
Define `intermediate_field K L` as a structure extending `subalgebra K L` and `subfield L`. This definition required some changes in `subalgebra`, which I added in #4180. Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
subalgebraextendsubsemiringinstead of usingsubsemiringas a field in its definition. The refactor is needed becauseintermediate_fieldshould simultaneously extendsubalgebraandsubfield, and so the type of thecarrierfields should match.I added some copies of definitions that use
subringinstead ofis_subringif I needed to change these definitions anyway.