Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(multiset): dedicated notation for multiset.cons #4600

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - chore(multiset): dedicated notation for multiset.cons #4600

wants to merge 3 commits into from

Conversation

jcommelin
Copy link
Member

@jcommelin jcommelin added the awaiting-review The author would like community review of the PR label Oct 13, 2020
gebner
gebner approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@gebner gebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @digama0 has strong opinions on list notations.

@digama0 digama0 added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 13, 2020
@jcommelin jcommelin added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 13, 2020
@jcommelin jcommelin mentioned this pull request Oct 13, 2020
Closed
1 task
bryangingechen
bryangingechen approved these changes Oct 13, 2020
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the new notation to the module doc string of data.multiset.

Otherwise LGTM.
bors d+

@bors
Copy link

bors bot commented Oct 13, 2020

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bryangingechen bryangingechen added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 13, 2020
@jcommelin
Copy link
Member Author

bors push

@bryangingechen
Copy link
Collaborator

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 13, 2020
bors bot pushed a commit that referenced this pull request Oct 13, 2020
@jcommelin
chore(multiset): dedicated notation for multiset.cons (#4600)
fde3d78
@jcommelin
Copy link
Member Author

Aaahrg.... too many commands... too many options

@bors
Copy link

bors bot commented Oct 13, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(multiset): dedicated notation for multiset.cons [Merged by Bors] - chore(multiset): dedicated notation for multiset.cons Oct 13, 2020
@bors bors bot closed this Oct 13, 2020
@bors bors bot deleted the multiset-cons branch October 13, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 digama0 left review comments

@gebner gebner gebner approved these changes

@bryangingechen bryangingechen bryangingechen approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcommelin @bryangingechen @gebner @digama0