Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/char_zero): char_zero.infinite #4593

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(algebra/char_zero): char_zero.infinite #4593

wants to merge 4 commits into from

Conversation

jcommelin
Copy link
Member

@jcommelin jcommelin commented Oct 13, 2020 •
edited by github-actions bot

@jcommelin jcommelin added the awaiting-review The author would like community review of the PR label Oct 13, 2020
@bors
Copy link

bors bot commented Oct 13, 2020

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

fpvandoorn
fpvandoorn reviewed Oct 13, 2020
View reviewed changes
Copy link
Member

@fpvandoorn fpvandoorn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
infinite.nonempty can now be proven using by apply_instance if you move it below infinite.nontrivial. Could you also make it a lemma?

bors d+

@fpvandoorn fpvandoorn added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 13, 2020
@jcommelin jcommelin added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 13, 2020
@jcommelin jcommelin removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 14, 2020
@jcommelin
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 14, 2020
bors bot pushed a commit that referenced this pull request Oct 14, 2020
@jcommelin
feat(algebra/char_zero): char_zero.infinite (#4593)
ede95c3
@bors
Copy link

bors bot commented Oct 14, 2020

Build failed:

@jcommelin
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Oct 14, 2020
@jcommelin
feat(algebra/char_zero): char_zero.infinite (#4593)
f7edbca
@bors
Copy link

bors bot commented Oct 14, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/char_zero): char_zero.infinite [Merged by Bors] - feat(algebra/char_zero): char_zero.infinite Oct 14, 2020
@bors bors bot closed this Oct 14, 2020
@bors bors bot deleted the chebpoly-preps branch October 14, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpvandoorn fpvandoorn fpvandoorn left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcommelin @fpvandoorn