-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(measure_theory/independence): define independence of sets of sets, measurable spaces, sets, functions #5848
Conversation
Great to see a new area start to be filled out! Could you update |
If you're feeling ambitious you could also introduce notation for independence. As a contrived demo: def indep { A : Type*} (μ : ℕ) (a b : A) : Prop := sorry
def Indep { A B : Type*} (μ : ℕ) (f : B → A) : Prop := sorry
-- assuming the "indepedent" (⫫) of probability is suitable here:
infix ` ⫫ `:50 := indep _
notation a ` ⫫[` μ `] ` b :50 := indep μ a b
notation `⫫ `:65 := indep
notation `⫫` binders `, ` r:(scoped:67 f, Indep _ f) := r
notation `⫫[` μ `]` binders `, ` r:(scoped:67 f, Indep μ f) := r
variables {A B : Type*} (a b : A) (f : B → A) (μ : ℕ) -- obviously mu should be a measure, I'm lazy
#check a ⫫[μ] b
#check a ⫫ b
#check (⫫ i, f i)
#check (⫫[μ] i, f i) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the math structure is good. I have a problem with the terminology in many docstrings, coming from the fact that "measurable space" means a space with a sigma-algebra in maths, and a sigma-algebra on an already given space in Lean. You could avoid the ambiguity by replacing "measurable space" with "measurable space structure" in many docstrings, to indicate that you are not introducing a new space, only a new measurable structure.
I have pushed minor changes:
I have checked what you've done, and I am very happy with it. You should my changes before this can be merged, though! bors d+ |
✌️ RemyDegenne can now approve this pull request. To approve and merge a pull request, simply reply with |
@sgouezel, do you have any thoughts on my notation suggestion in #5848 (comment)? |
It's a nice suggestion. However, in most probability theory papers this kind of notation is not used, and independence is spellt out explicitly. So I would say it's good to have it but I am not sure it should become the normal form to express independence in mathlib. In any case, it can wait for a later PR unless Rémy wants to add it now. |
Waiting for a later PR is probably a good idea anyway |
I will not add the notation to this PR, and to be honest I am not completely sure about its utility. The |
bors r+ |
…s, measurable spaces, sets, functions (#5848) This first PR about independence contains definitions, a few lemmas about independence of unions/intersections of sets of sets, and a proof that two measurable spaces are independent iff generating pi-systems are independent (included in this PR to demonstrate usability of the definitions). Co-authored-by: Rémy Degenne <remydegenne@gmail.com> Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Yes, I expect that |
Build failed (retrying...): |
Canceled. |
bors r+ |
…s, measurable spaces, sets, functions (#5848) This first PR about independence contains definitions, a few lemmas about independence of unions/intersections of sets of sets, and a proof that two measurable spaces are independent iff generating pi-systems are independent (included in this PR to demonstrate usability of the definitions). Co-authored-by: Rémy Degenne <remydegenne@gmail.com> Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Pull request successfully merged into master. Build succeeded: |
…s, measurable spaces, sets, functions (#5848) This first PR about independence contains definitions, a few lemmas about independence of unions/intersections of sets of sets, and a proof that two measurable spaces are independent iff generating pi-systems are independent (included in this PR to demonstrate usability of the definitions). Co-authored-by: Rémy Degenne <remydegenne@gmail.com> Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
This first PR about independence contains definitions, a few lemmas about independence of unions/intersections of sets of sets, and a proof that two measurable spaces are independent iff generating pi-systems are independent (included in this PR to demonstrate usability of the definitions).
The plan is to follow with the content of the file
independence.lean
on theindependence
branch: