Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap for finmap #738

Closed
cipher1024 opened this issue Feb 18, 2019 · 5 comments
Closed

Roadmap for finmap #738

cipher1024 opened this issue Feb 18, 2019 · 5 comments
Assignees

Comments

@cipher1024
Copy link
Collaborator

No description provided.

@cipher1024
Copy link
Collaborator Author

@spl: do you plan on splitting finmap and dfinmap`?

@spl
Copy link
Collaborator

spl commented Feb 19, 2019

@cipher1024 In the future, can you please fill in a description for an issue that you create and assign it to me? Are you asking me to define a roadmap of my plans for finmap?

(Aside: I haven't seen roadmaps provided for any other aspects of mathlib, so it makes me wonder why finmap needs one. Nonetheless, that doesn't mean I'm not happy to contribute. Roadmaps are always nice to have.)

do you plan on splitting finmap and dfinmap?

I believe you are referring to #662 (comment). I don't plan to do something like that in the immediate timeframe. (Also, I still don't know the best way to do that at the moment, and I haven't looked into it.)

My first priority is to bring finmap in mathlib up the level of usability (i.e. available definitions and theorems) found in https://github.com/spl/lean-finmap. Since it was introduced to mathlib with a different approach, it's not straightforward to bring over what I have. #722 was just the first step in that direction.

After that, I don't have concrete plans for finmap. It may be useful to create a non-dependent finmap at that point.

@cipher1024
Copy link
Collaborator Author

Actually, I don't see it as additional homework. It was a way for me to open up a conversation about finmap and having a peek at your thinking. On one hand, if you need help with something, on another hand what features you considered and haven't considered. I'm getting started on graph algorithms and their are specific things I'm going to need from finmap. I'd like to coordinate.

@cipher1024
Copy link
Collaborator Author

@spl

In the future, can you please fill in a description for an issue that you create and assign it to me?

I will. I apologize for the oversight.

@spl
Copy link
Collaborator

spl commented Feb 20, 2019

Actually, I don't see it as additional homework. It was a way for me to open up a conversation about finmap and having a peek at your thinking. On one hand, if you need help with something, on another hand what features you considered and haven't considered. I'm getting started on graph algorithms and their are specific things I'm going to need from finmap. I'd like to coordinate.

@cipher1024 And I'm happy to coordinate. It's just a bit difficult to deduce what you're going for without the above context. 😉

I don't need help at the moment. The next things I'll port over are union and disjoint for keys.

What do you need from finmap?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants