feat(data/alist,data/finmap): always insert key-value pair #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed {alist,finmap}.insert to always insert the key-value pair
instead of doing nothing if the inserted key is found. This allows for
useful theorems such as lookup_insert.
* Added list.keys and used key membership instead of exists/forall. This
makes proofs easier in some places.
* Added a few other useful theorems such as lookup_eq_none,
lookup_erase, lookup_erase_ne.
cipher1024
approved these changes
Feb 13, 2019
|
Any feedback on this? I'd like to continue building on top of it but don't want to start if it's not going to be accepted. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{alist,finmap}.insertto always insert the key-value pair instead of doing nothing if the inserted key is found. This allows for useful theorems such aslookup_insert.list.keysand used key membership instead of exists/forall. This makes proofs easier in some places.lookup_eq_none,lookup_erase,lookup_erase_ne.