New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(model_theory/basic): First-order languages, structures, homomorphisms, embeddings, and equivs #7754
Conversation
nice work, LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
bors d+ |
✌️ awainverse can now approve this pull request. To approve and merge a pull request, simply reply with |
Could you add a |
I was planning on creating a file of algebra examples in a follow-up PR. Would it suffice to post that separate PR as a proof-of-concept, and then merge this one? |
(I'll be following closely to https://github.com/flypitch/flypitch/blob/lean-3.14.0/src/abel.lean) |
I have an example at https://github.com/leanprover-community/mathlib/tree/fo_monoid |
bors r+ |
…hisms, embeddings, and equivs (#7754) Defines the following notions from first-order logic: - languages - structures - homomorphisms - embeddings - equivalences (isomorphisms) The definitions of languages and structures take inspiration from the Flypitch project.
Build failed (retrying...): |
…hisms, embeddings, and equivs (#7754) Defines the following notions from first-order logic: - languages - structures - homomorphisms - embeddings - equivalences (isomorphisms) The definitions of languages and structures take inspiration from the Flypitch project.
Build failed (retrying...): |
…hisms, embeddings, and equivs (#7754) Defines the following notions from first-order logic: - languages - structures - homomorphisms - embeddings - equivalences (isomorphisms) The definitions of languages and structures take inspiration from the Flypitch project.
Pull request successfully merged into master. Build succeeded: |
How does |
So far, I only have the ability to define a structure in the language of monoids, which is just a type with |
Defines the following notions from first-order logic:
The definitions of languages and structures take inspiration from the Flypitch project.