Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(model_theory/basic): Substructures #7762

Closed
wants to merge 7 commits into from

Conversation

awainverse
Copy link
Collaborator

@awainverse awainverse commented May 31, 2021

@awainverse awainverse added awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels May 31, 2021
@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jun 9, 2021
@github-actions
Copy link

github-actions bot commented Jun 9, 2021

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jun 9, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jun 9, 2021
src/model_theory/basic.lean Outdated Show resolved Hide resolved
Comment on lines 469 to 470
/-- The `L.substructure` generated by a set. -/
def closure (s : set M) : L.substructure M := Inf {S | s ⊆ S}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth the effort to instead define closure as a lower_adjoint (coe : L.substructure M → set M) and get a lot of the following lemmas (and quite a few additional ones!) for free. However, lower_adjoint doesn't seem to be used yet in mathlib, so it's fine if you want to leave that to someone else.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

There's probably a better way to connect lower_adjoint to gi, but it does require an additional assumption (that the upper adjoint has the property that u x <= u y implies x <= y). I think this could at least be done at the level of set_like, but perhaps that's for a different PR.

@Vierkantor Vierkantor added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 15, 2021
@awainverse awainverse added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 16, 2021
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 16, 2021
bors bot pushed a commit that referenced this pull request Jun 17, 2021
Defines substructures of first-order structures
@bors
Copy link

bors bot commented Jun 17, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(model_theory/basic): Substructures [Merged by Bors] - feat(model_theory/basic): Substructures Jun 17, 2021
@bors bors bot closed this Jun 17, 2021
@bors bors bot deleted the substructures branch June 17, 2021 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants