Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(linear_algebra/free_module): add class module.free #7801

Closed
wants to merge 24 commits into from
Closed

[Merged by Bors] - feat(linear_algebra/free_module): add class module.free #7801

wants to merge 24 commits into from

Conversation

riccardobrasca
Copy link
Member

@riccardobrasca riccardobrasca commented Jun 2, 2021 •
edited
Loading

We introduce here a new class module.free.

Open in Gitpod

@riccardobrasca riccardobrasca added the awaiting-review The author would like community review of the PR label Jun 2, 2021
@riccardobrasca
Copy link
Member Author

I decided to open a normal PR following the WIP PR #7722. There are of course other instances to add, and also start using this class somewhere :)

@riccardobrasca
Copy link
Member Author

Note that I changed the name of free_module to free_module_pid, and created a totally different free_module... so the diff can be a little confusing.

@riccardobrasca riccardobrasca mentioned this pull request Jun 2, 2021
Closed
bors bot pushed a commit that referenced this pull request Jun 3, 2021
@riccardobrasca
chore(src/linear_algebra/free_module): rename file to free_module_pid (…
2a93644 
…#7805)

In preparation for #7801
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jun 3, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jun 4, 2021
@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 4, 2021
riccardobrasca and others added 3 commits June 4, 2021 11:19
@riccardobrasca @eric-wieser
Update src/linear_algebra/free_module.lean
edd60c5 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@riccardobrasca @eric-wieser
Update src/linear_algebra/free_module.lean
d186add 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@riccardobrasca
long line
f64dfe9
@riccardobrasca riccardobrasca added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 4, 2021
riccardobrasca and others added 2 commits June 4, 2021 12:28
@riccardobrasca @eric-wieser
Update src/linear_algebra/free_module.lean
9c13e99 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@riccardobrasca @eric-wieser
Update src/linear_algebra/free_module.lean
401e204 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@adamtopaz
Copy link
Collaborator

This PR looks great so far!

Would you mind adding the universal property of the free module? I.e. that, for a free module M, the type of linear maps from M to another module N is in (canon) bijection with the type of functions from choose_basis_index M to N.

@riccardobrasca riccardobrasca mentioned this pull request Jun 7, 2021
Closed
jcommelin
jcommelin reviewed Jun 8, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/linear_algebra/free_module.lean Outdated Show resolved Hide resolved
jcommelin
jcommelin reviewed Jun 11, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks about names

src/linear_algebra/free_module.lean Outdated Show resolved Hide resolved
src/linear_algebra/free_module.lean Outdated Show resolved Hide resolved
src/linear_algebra/free_module.lean Outdated Show resolved Hide resolved
src/linear_algebra/free_module.lean Outdated Show resolved Hide resolved
src/linear_algebra/free_module.lean Outdated Show resolved Hide resolved
jcommelin
jcommelin approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 11, 2021
bors bot pushed a commit that referenced this pull request Jun 11, 2021
@riccardobrasca @jcommelin
feat(linear_algebra/free_module): add class module.free (#7801)
7a8b451 
We introduce here a new class `module.free`.



Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jun 11, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jun 11, 2021
@riccardobrasca @jcommelin
feat(linear_algebra/free_module): add class module.free (#7801)
7002d9c 
We introduce here a new class `module.free`.



Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jun 11, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jun 12, 2021
@riccardobrasca @jcommelin
feat(linear_algebra/free_module): add class module.free (#7801)
736c40b 
We introduce here a new class `module.free`.



Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jun 12, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jun 12, 2021
@riccardobrasca @jcommelin
feat(linear_algebra/free_module): add class module.free (#7801)
06094d5 
We introduce here a new class `module.free`.



Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jun 12, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/free_module): add class module.free [Merged by Bors] - feat(linear_algebra/free_module): add class module.free Jun 12, 2021
@bors bors bot closed this Jun 12, 2021
@bors bors bot deleted the class_free_mod branch June 12, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@adamtopaz adamtopaz adamtopaz left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@riccardobrasca @adamtopaz @eric-wieser @jcommelin