[Merged by Bors] - feat(tactic/lint): better fails_quickly linter #8932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpvandoorn
added
WIP
This was referenced Aug 31, 2021
bors bot
pushed a commit
that referenced
this pull request
Aug 31, 2021
…e` (#8933) Previously, this instance would first look for `decidable_eq` instances and after that for `is_simple_lattice` instances. The latter has only 4 instances, while the former takes hundreds of steps. Reordering the arguments makes a lot of type-class searches fail a lot quicker. Caught by the new linter (#8932).
bors bot
pushed a commit
that referenced
this pull request
Aug 31, 2021
This instance causes loop with `is_total_preorder.to_is_total`, and was unused in the library. Caught by the new linter (#8932).
fpvandoorn
added
awaiting-review
Is the plan to do these as part of this PR, or later? |
|
The first I sort-of did (by just setting the The status is: we might not fix them in Lean 3 if the Lean 4 loop-checking catches these loops. I haven't done the tests in Lean 4. Even if we're fixing them in Lean 3, it will be in a follow-up PR. |
github-actions
bot
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 9, 2021
This linter catches a lot more loops. Co-authored-by: Floris van Doorn <fpv@andrew.cmu.edu>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
PatrickMassot
added a commit
that referenced
this pull request
Oct 3, 2021
This reverts commit 4d88ae8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This linter catches a lot more loops.
TODO:
max_steps[ ] fix some/all problematic instances it catches