Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix(order/rel_classes): remove looping instance #8931

Closed
wants to merge 1 commit into from

Conversation

fpvandoorn
Copy link
Member

@fpvandoorn fpvandoorn commented Aug 31, 2021

This instance causes loop with is_total_preorder.to_is_total, and was unused in the library.

Caught by the new linter (#8932).


Open in Gitpod

@fpvandoorn fpvandoorn added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Aug 31, 2021
@sgouezel
Copy link
Collaborator

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 31, 2021
bors bot pushed a commit that referenced this pull request Aug 31, 2021
This instance causes loop with `is_total_preorder.to_is_total`, and was unused in the library.

Caught by the new linter (#8932).
@bors
Copy link

bors bot commented Aug 31, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(order/rel_classes): remove looping instance [Merged by Bors] - fix(order/rel_classes): remove looping instance Aug 31, 2021
@bors bors bot closed this Aug 31, 2021
@bors bors bot deleted the looping_instances branch August 31, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants