Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(linear_algebra/matrix/circulant): add a file #9011

Closed
wants to merge 57 commits into from
Closed

[Merged by Bors] - feat(linear_algebra/matrix/circulant): add a file #9011

wants to merge 57 commits into from

Conversation

l534zhan
Copy link
Collaborator

@l534zhan l534zhan commented Sep 4, 2021

Open in Gitpod

@l534zhan
Copy link
Collaborator Author

l534zhan commented Sep 4, 2021

This is a PR is a part of a project. See https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/Contribute.20a.20project.

@l534zhan l534zhan added the awaiting-review The author would like community review of the PR label Sep 4, 2021
l534zhan and others added 2 commits September 5, 2021 20:02
@l534zhan @eric-wieser
Update src/linear_algebra/matrix/circulant.lean
476ca9d 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@l534zhan
change
3513c0c
l534zhan and others added 2 commits September 6, 2021 14:45
@l534zhan @eric-wieser
Update src/linear_algebra/matrix/circulant.lean
ecdf441 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@l534zhan
change
962769f
jcommelin
jcommelin reviewed Sep 8, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it makes sense to have a predicate is_circulant that asserts that a matrix is equal to the circulant of its 0th column?

src/linear_algebra/matrix/circulant.lean Show resolved Hide resolved
src/linear_algebra/matrix/circulant.lean Outdated Show resolved Hide resolved
src/linear_algebra/matrix/circulant.lean Outdated Show resolved Hide resolved
src/linear_algebra/matrix/circulant.lean Outdated Show resolved Hide resolved
src/linear_algebra/matrix/circulant.lean Outdated Show resolved Hide resolved
@jcommelin
Copy link
Member

I pushed a golf of the fin.* lemmas.

l534zhan and others added 4 commits September 8, 2021 11:44
@l534zhan @jcommelin
Update src/linear_algebra/matrix/circulant.lean
0f9631a 
Co-authored-by: Johan Commelin <johan@commelin.net>
@l534zhan @jcommelin
Update src/linear_algebra/matrix/circulant.lean
0fa2046 
Co-authored-by: Johan Commelin <johan@commelin.net>
@l534zhan @jcommelin
Update src/linear_algebra/matrix/circulant.lean
045cccf 
Co-authored-by: Johan Commelin <johan@commelin.net>
@l534zhan
change
f2b02ef
l534zhan and others added 4 commits September 13, 2021 15:04
@l534zhan @eric-wieser
Update src/linear_algebra/matrix/circulant.lean
8d6b32c 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@l534zhan @eric-wieser
Update src/linear_algebra/matrix/circulant.lean
f5a1bc5 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@l534zhan
change
aa3f7e5
@l534zhan
change
04cf6c0
eric-wieser
eric-wieser reviewed Sep 13, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are the only two lemmas that use n : nat. If you add {n} to their argument lists then you are free to rename I J to m n

src/linear_algebra/matrix/circulant.lean Outdated Show resolved Hide resolved
src/linear_algebra/matrix/circulant.lean Outdated Show resolved Hide resolved
@l534zhan
Copy link
Collaborator Author

I think these are the only two lemmas that use n : nat. If you add {n} to their argument lists then you are free to rename I J to m n

This solution seems better.

l534zhan and others added 3 commits September 13, 2021 15:56
@l534zhan @eric-wieser
Update src/linear_algebra/matrix/circulant.lean
49eea71 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@l534zhan @eric-wieser
Update src/linear_algebra/matrix/circulant.lean
5a3ce72 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@l534zhan
change
4da657c
eric-wieser
eric-wieser reviewed Sep 13, 2021
View reviewed changes
src/linear_algebra/matrix/circulant.lean Outdated Show resolved Hide resolved
src/linear_algebra/matrix/circulant.lean Outdated Show resolved Hide resolved
src/linear_algebra/matrix/circulant.lean Outdated Show resolved Hide resolved
src/linear_algebra/matrix/circulant.lean Outdated Show resolved Hide resolved
src/linear_algebra/matrix/circulant.lean Outdated Show resolved Hide resolved
l534zhan and others added 2 commits September 13, 2021 16:29
@l534zhan @eric-wieser
Update src/linear_algebra/matrix/circulant.lean
acb1470 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@l534zhan
change
5b507d4
@l534zhan
Copy link
Collaborator Author

updated @eric-wieser

eric-wieser
eric-wieser approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Any final comments @jcommelin?

jcommelin
jcommelin approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 14, 2021
bors bot pushed a commit that referenced this pull request Sep 14, 2021
@l534zhan @jcommelin
feat(linear_algebra/matrix/circulant): add a file (#9011)
f0a1356 


Co-authored-by: l534zhan <84618936+l534zhan@users.noreply.github.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Sep 14, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/matrix/circulant): add a file [Merged by Bors] - feat(linear_algebra/matrix/circulant): add a file Sep 14, 2021
@bors bors bot closed this Sep 14, 2021
@bors bors bot deleted the cir_lz branch September 14, 2021 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@l534zhan @jcommelin @eric-wieser