This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Merged by Bors] - feat(linear_algebra/matrix/circulant): add a file #9011
[Merged by Bors] - feat(linear_algebra/matrix/circulant): add a file #9011
Changes from 8 commits
57b76d8
f194203
476ca9d
3513c0c
ecdf441
962769f
aca4d54
b2ad283
84e5e8a
0f9631a
0fa2046
045cccf
f2b02ef
57816ca
b54d5df
d61ab55
8e7fb7c
7ad0bdb
539a881
6337781
73988d5
17ad2f0
67b8471
0016477
f28d2d5
910bce6
0b7279c
025a269
99ec4e6
68e4cea
abbde3b
a86d601
84d3c7b
8142022
4bfb919
c360edf
59f34f0
94e98dd
3a10e74
30a5de6
aadc7fb
d89c1fe
651521c
b386251
2e1dc25
a3593b6
061cf74
8d6b32c
f5a1bc5
aa3f7e5
04cf6c0
49eea71
5a3ce72
4da657c
acb1470
5b507d4
911a3a0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would guess you can replace all the proofs like this with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think
ext $ λ _ _, rfl
will do for the most lemmas. Perhaps some variant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be surprised if this doesn't already exist somewhere. At any rate, this belongs somewhere in one of the polynomial files, perhaps as
polynomial_of_fin_coeffs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what do I need to do with this one now? @eric-wieser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should:
data/polynomial/coeff
and call itpolynomial_of_fin_coeffs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have deleted the last two lemmas for now. We can do a new PR in the future concerning the algebra aspect or add back to this one if there is a simple answer.