[Merged by Bors] - feat(linear_algebra/direct_sum): submodule_is_internal_iff_independent_and_supr_eq_top
#9214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also golf some uses of `quotient.lift_on` to use `quotient.map`.
…uotient.lift_on`" This reverts commit 7f136ef.
github-actions
bot
added
the
blocked-by-other-PR
eric-wieser
changed the title
complete_lattice.independent_iff_dfinsupp_lsum_kersubmodule_is_internal_iff_independent_and_supr_eq_top
github-actions
bot
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
…p-injective-independent
github-actions
bot
added
merge-conflict
|
🎉 Great news! Looks like all the dependencies have been resolved:
💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
github-actions
bot
removed
the
merge-conflict
eric-wieser
commented
Sep 25, 2021
eric-wieser
added
the
awaiting-review
eric-wieser
commented
Sep 30, 2021
semorrison
reviewed
Oct 1, 2021
semorrison
reviewed
Oct 1, 2021
|
bors d+ |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
jcommelin
reviewed
Oct 1, 2021
jcommelin
added
the
awaiting-author
Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Johan Commelin <johan@commelin.net>
eric-wieser
added
awaiting-review
jcommelin
added
awaiting-CI
|
Thanks 🎉 bors merge |
github-actions
bot
added
the
ready-to-merge
|
I'm a little puzzled by bors here. This PR has the label "awaiting-CI" but bors did not reject it. As far as I know bors uses the configuration from the master branch, which indeed contains: Line 7 in c33407a |
|
Perhaps bors won't reject it until it hits the top of the queue? |
|
Ah, I misremembered! From the docs
|
bryangingechen
removed
the
awaiting-CI
bors bot
pushed a commit
that referenced
this pull request
Oct 1, 2021
…nt_and_supr_eq_top` (#9214) This shows that a grade decomposition into submodules is bijective iff and only iff the submodules are independent and span the whole module. The key proofs are: * `complete_lattice.independent_of_dfinsupp_lsum_injective` * `complete_lattice.independent.dfinsupp_lsum_injective` Everything else is just glue. This replaces parts of #8246, and uses what is probably a similar proof strategy, but without unfolding down to finsets. Unlike the proof there, this requires only `add_comm_monoid` for the `complete_lattice.independent_of_dfinsupp_lsum_injective` direction of the proof. I was not able to find a proof of `complete_lattice.independent.dfinsupp_lsum_injective` with the same weak assumptions, as it is not true! A counter-example is included, Co-authored-by: Hanting Zhang <hantingzhang03@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
submodule_is_internal_iff_independent_and_supr_eq_topsubmodule_is_internal_iff_independent_and_supr_eq_top
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows that a grade decomposition into submodules is bijective iff and only iff the submodules are independent and span the whole module.
The key proofs are:
complete_lattice.independent_of_dfinsupp_lsum_injectivecomplete_lattice.independent.dfinsupp_lsum_injectiveEverything else is just glue.
This replaces parts of #8246, and uses what is probably a similar proof strategy, but without unfolding down to finsets.
Unlike the proof there, this requires only
add_comm_monoidfor thecomplete_lattice.independent_of_dfinsupp_lsum_injectivedirection of the proof. I was not able to find a proof ofcomplete_lattice.independent.dfinsupp_lsum_injectivewith the same weak assumptions, as it is not true! A counter-example is included,Co-authored-by: Hanting Zhang hantingzhang03@gmail.com
filter_ne_eq_erase#9182