Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(field_theory/separable): X^n - 1 is separable iff ↑n ≠ 0. #9779

Closed
wants to merge 6 commits into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Oct 17, 2021

Most of the proof actually due to @Vierkantor!

Co-authored-by: Anne Baanen t.baanen@vu.nl


Open in Gitpod

@ericrbg ericrbg added the awaiting-review The author would like community review of the PR label Oct 17, 2021
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 19, 2021
@ericrbg ericrbg added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 19, 2021
@Vierkantor Vierkantor self-requested a review October 21, 2021 10:35
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I managed to show your result for nontrivial comm_rings 🎉

Since I wrote most of the code in the suggestion, I'll leave the final approval to another maintainer.

src/field_theory/separable.lean Outdated Show resolved Hide resolved
src/field_theory/separable.lean Outdated Show resolved Hide resolved
@ericrbg
Copy link
Collaborator Author

ericrbg commented Nov 9, 2021

oh no... I need to fix this merge commit

src/field_theory/separable.lean Outdated Show resolved Hide resolved
src/field_theory/separable.lean Outdated Show resolved Hide resolved
thanks Anne!

Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 11, 2021
bors bot pushed a commit that referenced this pull request Nov 11, 2021
Most of the proof actually due to @Vierkantor!

Co-authored-by: Anne Baanen <t.baanen@vu.nl>



Co-authored-by: Eric <37984851+ericrbg@users.noreply.github.com>
@bors
Copy link

bors bot commented Nov 11, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Nov 11, 2021
Most of the proof actually due to @Vierkantor!

Co-authored-by: Anne Baanen <t.baanen@vu.nl>



Co-authored-by: Eric <37984851+ericrbg@users.noreply.github.com>
@bors
Copy link

bors bot commented Nov 12, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(field_theory/separable): X^n - 1 is separable iff ↑n ≠ 0. [Merged by Bors] - feat(field_theory/separable): X^n - 1 is separable iff ↑n ≠ 0. Nov 12, 2021
@bors bors bot closed this Nov 12, 2021
@bors bors bot deleted the separable-X_pow_sub_one branch November 12, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants