New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(field_theory/separable): X^n - 1 is separable iff ↑n ≠ 0. #9779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I managed to show your result for nontrivial comm_ring
s 🎉
Since I wrote most of the code in the suggestion, I'll leave the final approval to another maintainer.
oh no... I need to fix this merge commit |
3e30e67
to
526963f
Compare
thanks Anne! Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
Most of the proof actually due to @Vierkantor! Co-authored-by: Anne Baanen <t.baanen@vu.nl> Co-authored-by: Eric <37984851+ericrbg@users.noreply.github.com>
Build failed (retrying...): |
Most of the proof actually due to @Vierkantor! Co-authored-by: Anne Baanen <t.baanen@vu.nl> Co-authored-by: Eric <37984851+ericrbg@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
Most of the proof actually due to @Vierkantor!
Co-authored-by: Anne Baanen t.baanen@vu.nl