-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(algebra/group/inj_surj): add 2 missing def
s
#10068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix one `to_additive` name.
urkud
added
awaiting-review
The author would like community review of the PR
awaiting-CI
The author would like to see what CI has to say before doing more work.
and removed
awaiting-CI
The author would like to see what CI has to say before doing more work.
labels
Oct 31, 2021
Your PR description looks wrong to me |
eric-wieser
approved these changes
Oct 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
The PR author may merge after reviewing final suggestions.
and removed
awaiting-review
The author would like community review of the PR
labels
Oct 31, 2021
bors merge |
github-actions
bot
added
the
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
label
Oct 31, 2021
bors bot
pushed a commit
that referenced
this pull request
Oct 31, 2021
`function.injective.right_cancel_monoid` and `function.injective.cancel_monoid` were missing. `function.injective.sub_neg_monoid` was also misnamed `function.injective.sub_neg_add_monoid`. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
chore(algebra/group/inj_surj): add 2 missing
[Merged by Bors] - chore(algebra/group/inj_surj): add 2 missing Oct 31, 2021
def
sdef
s
ericrbg
pushed a commit
that referenced
this pull request
Nov 9, 2021
`function.injective.right_cancel_monoid` and `function.injective.cancel_monoid` were missing. `function.injective.sub_neg_monoid` was also misnamed `function.injective.sub_neg_add_monoid`. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
delegated
The PR author may merge after reviewing final suggestions.
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
function.injective.right_cancel_monoid
andfunction.injective.cancel_monoid
were missing.function.injective.sub_neg_monoid
was also misnamedfunction.injective.sub_neg_add_monoid
.