Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(algebra/group/inj_surj): add 2 missing defs #10068

Closed
wants to merge 2 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Oct 31, 2021

function.injective.right_cancel_monoid and function.injective.cancel_monoid were missing.

function.injective.sub_neg_monoid was also misnamed function.injective.sub_neg_add_monoid.


Open in Gitpod

Also fix one `to_additive` name.
@urkud urkud added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. and removed awaiting-CI The author would like to see what CI has to say before doing more work. labels Oct 31, 2021
@eric-wieser
Copy link
Member

Your PR description looks wrong to me

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@bors
Copy link

bors bot commented Oct 31, 2021

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 31, 2021
@eric-wieser
Copy link
Member

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 31, 2021
bors bot pushed a commit that referenced this pull request Oct 31, 2021
`function.injective.right_cancel_monoid` and `function.injective.cancel_monoid` were missing.

`function.injective.sub_neg_monoid` was also misnamed `function.injective.sub_neg_add_monoid`.



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Oct 31, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/group/inj_surj): add 2 missing defs [Merged by Bors] - chore(algebra/group/inj_surj): add 2 missing defs Oct 31, 2021
@bors bors bot closed this Oct 31, 2021
@bors bors bot deleted the YK-inj-instances branch October 31, 2021 15:39
ericrbg pushed a commit that referenced this pull request Nov 9, 2021
`function.injective.right_cancel_monoid` and `function.injective.cancel_monoid` were missing.

`function.injective.sub_neg_monoid` was also misnamed `function.injective.sub_neg_add_monoid`.



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants