[Merged by Bors] - refactor(order/bounded_lattice): generalize le on with_{top,bot} #10085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, some lemmas assumed `preorder` even when they were true for
just the underlying `le`. In the case of `with_bot`, the missing
underlying `has_le` instance is defined.
For both `with_{top,bot}`, a few lemmas are generalized accordingly.
pechersky
added
the
awaiting-review
1 task
eric-wieser
reviewed
Nov 2, 2021
| @@ -336,7 +336,7 @@ begin | |||
| end | |||
|
|
|||
| lemma one_le_iff_pos {n : with_top ℕ} : 1 ≤ n ↔ 0 < n := | |||
| ⟨λ h, (coe_lt_coe.2 zero_lt_one).trans_le h, | |||
| ⟨lt_of_lt_of_le (coe_lt_coe.mpr zero_lt_one), | |||
There was a problem hiding this comment.
Is this just a style change, or did something actually change here?
There was a problem hiding this comment.
Huh, somehow the elaborator now gets stuck. Weird.
|
bors merge |
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, some lemmas assumed
preordereven when they were true forjust the underlying
le. In the case ofwith_bot, the missingunderlying
has_leinstance is defined.For both
with_{top,bot}, a few lemmas are generalized accordingly.