Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/fintype): computable trunc bijection from fin #10141

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat(data/fintype): computable trunc bijection from fin #10141

wants to merge 9 commits into from

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Nov 3, 2021 •
edited

When a type X lacks decidable equality, there is still computably a bijection fin (card X) -> X using trunc.

Also, move fintype.equiv_fin_of_forall_mem_list to list.nodup.nth_le_equiv_of_forall_mem_list.

Open in Gitpod

@kmill kmill added the awaiting-review The author would like community review of the PR label Nov 4, 2021
@bryangingechen bryangingechen changed the title feature(data/fintype): computable trunc bijection from fin feat(data/fintype): computable trunc bijection from fin Nov 4, 2021
@kmill
Copy link
Collaborator Author

kmill commented Nov 4, 2021

Pinging @urkud since this touches data.list.nodup.equiv_fin

@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Nov 4, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Nov 4, 2021
@kmill kmill requested a review from urkud November 4, 2021 23:07
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Nov 10, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Nov 10, 2021
gebner
gebner reviewed Nov 10, 2021
View reviewed changes
src/data/fintype/basic.lean Outdated Show resolved Hide resolved
@kmill @gebner
correct docstring
6331437 
Co-authored-by: Gabriel Ebner <gebner@gebner.org>
jcommelin
jcommelin approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 15, 2021
bors bot pushed a commit that referenced this pull request Nov 15, 2021
@kmill
feat(data/fintype): computable trunc bijection from fin (#10141)
9c03e9d 
When a type `X` lacks decidable equality, there is still computably a bijection `fin (card X) -> X` using `trunc`.

Also, move `fintype.equiv_fin_of_forall_mem_list` to `list.nodup.nth_le_equiv_of_forall_mem_list`.
@bors
Copy link

bors bot commented Nov 15, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/fintype): computable trunc bijection from fin [Merged by Bors] - feat(data/fintype): computable trunc bijection from fin Nov 15, 2021
@bors bors bot closed this Nov 15, 2021
@bors bors bot deleted the kmill_fintype_trunc_bijective branch November 15, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner gebner left review comments

@eric-wieser eric-wieser eric-wieser left review comments

@jcommelin jcommelin jcommelin approved these changes

@urkud urkud Awaiting requested review from urkud

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kmill @gebner @eric-wieser @jcommelin