Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(archive/imo) : Add solution to IMO 1994 Q1 #10171

Closed
wants to merge 6 commits into from

Conversation

antoinelab01
Copy link
Collaborator

IMO 1994 Q1

Open in Gitpod

@antoinelab01 antoinelab01 added the awaiting-review The author would like community review of the PR label Nov 4, 2021
rw this, clear this,

-- The rest is a simple calculation by rearranging one of the two sums
calc 2 * ∑ i : fin (m+1), a i = ∑ i : fin (m+1), a i + ∑ i : fin (m+1), a i : two_mul _
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
calc 2 * ∑ i : fin (m+1), a i = ∑ i : fin (m+1), a i + ∑ i : fin (m+1), a i : two_mul _
calc 2 * ∑ i : fin (m+1), a i
= ∑ i : fin (m+1), a i + ∑ i : fin (m+1), a i : two_mul _

Please reformat the other lines as well. Hopefully they'll fit in ≤ 100 chars that way.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done!

@jcommelin
Copy link
Member

@antoinelab01 I pushed some golfs and tricks to the branch imo1994_q1_jmc

@antoinelab01
Copy link
Collaborator Author

@antoinelab01 I pushed some golfs and tricks to the branch imo1994_q1_jmc

Sorry, I'm still not very familiar with GitHub... I don't find this branch, where can I see it?

@jcommelin
Copy link
Member

You can see the diff here: imo1994_q1...imo1994_q1_jmc

@antoinelab01
Copy link
Collaborator Author

Thanks. How do I merge the golf you did to my pull request?

@jcommelin
Copy link
Member

@antoinelab01 Are you familiar with the command line? In your copy of mathlib, make sure you have checked out your branch:

git checkout imo1994_q1
git fetch # pull updates from github
git merge origin/imo1994_q1_jmc # merge the other branch into yours

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 8, 2021
bors bot pushed a commit that referenced this pull request Nov 8, 2021
IMO 1994 Q1


Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Nov 8, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(archive/imo) : Add solution to IMO 1994 Q1 [Merged by Bors] - feat(archive/imo) : Add solution to IMO 1994 Q1 Nov 8, 2021
@bors bors bot closed this Nov 8, 2021
@bors bors bot deleted the imo1994_q1 branch November 8, 2021 10:06
ericrbg pushed a commit that referenced this pull request Nov 9, 2021
IMO 1994 Q1


Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants