-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(data/matrix/notation): split into 2 files #10199
Conversation
import data.matrix.notation | ||
import data.fin.vec_notation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you look through the other 13 files that import this and see if they can be relaxed too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
CI is failing because these two lemmas need to move to the mathlib/src/data/matrix/notation.lean Line 210 in e714e39
mathlib/src/data/matrix/notation.lean Lines 214 to 216 in e714e39
|
-/ | ||
instance [has_repr α] : has_repr (fin n → α) := | ||
{ repr := λ f, "![" ++ (string.intercalate ", " ((list.fin_range n).map (λ n, repr (f n)))) ++ "]" } | ||
|
||
/-- Use `![...]` notation for displaying a `fin`-indexed matrix, for example: | ||
|
||
``` | ||
#eval ![![1, 2], ![3, 4]] + ![![3, 4], ![5, 6]] -- ![![4, 6], ![8, 10]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example is weird, because lean doesn't even know this has type matrix
so doesn't use this instance. Out of scope I guess though, since it was here before.
Then it will have to import |
I think that's fine. If it becomes a problem in future, then I'd argue the solution is to split a |
bors d+ The CI failure is weird |
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
bors merge |
I want to use `![a, b]` notation in some files that don't need to import `data.matrix.basic`.
Pull request successfully merged into master. Build succeeded: |
I want to use `![a, b]` notation in some files that don't need to import `data.matrix.basic`.
I want to use
![a, b]
notation in some files that don't need to importdata.matrix.basic
.