Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(ring_theory,algebraic_geometry): Miscellaneous lemmas/def/typo corrections #10307
[Merged by Bors] - feat(ring_theory,algebraic_geometry): Miscellaneous lemmas/def/typo corrections #10307
Changes from all commits
3c8b55b
16eddd5
5b5e122
9167c12
af8e3ce
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
@
suggests that maybecover_dense.restrict_hom_equiv_hom
needs more explicit arguments?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sites version of
restrict_hom_equiv_hom
hasF
andF'
implicit, and here only theF'
argument (namely(presheaf.Sheaf_spaces_to_sheaf_sites C X).obj F'
) can't be inferred. I imagine this argument will need to be made explicit only at this point where we bridge sites and spaces.However, the spaces version I added has both
F
andF'
explicit; this is because in my Gamma-Spec work I found that supplying one of them helped with unification (andF
has to come beforeh
to make this work, which is also inconsistent with the sites version). If I don't supply(structure_sheaf (Γ' X)).1
, the following error would appear:Same error occurs even if I supply implicit argument
Γ' X
tois_basis_basic_opens
, or changeλ r : R, basic_open r
to@basic_open R _
in the definition ofis_basis_basic_opens
.Overall, if consistency (of argument explicitness/order) isn't a strict requirement, I think the current status is satisfactory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks for the explanation!