Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/calculus/times_cont_diff): continuous affine maps are smooth #10335

Closed
wants to merge 3 commits into from

Conversation

ocfnash
Copy link
Collaborator

@ocfnash ocfnash commented Nov 15, 2021

Formalized as part of the Sphere Eversion project.


I considered placing this next to the lemma continuous_linear_map.times_cont_diff but I chose not to because:

  • I need to use times_cont_diff.add which only appears about 500 lines lower down in the same file (analysis/calculus/times_cont_diff.lean)
  • The file analysis/calculus/times_cont_diff.lean is already 3000 lines long
  • It seems a shame to make all of calculus depend upon the theory of affine spaces just for this one lemma

Open in Gitpod

@ocfnash ocfnash added the awaiting-review The author would like community review of the PR label Nov 15, 2021
@sgouezel
Copy link
Collaborator

Could you put it into its own file? Here you are importing all of calculus into continuous_affine_map, which is not much better.

@sgouezel
Copy link
Collaborator

Move it to calculus and I'm gonna be happy :-)
bors d+

@bors
Copy link

bors bot commented Nov 15, 2021

✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Nov 15, 2021
@ocfnash
Copy link
Collaborator Author

ocfnash commented Nov 15, 2021

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Nov 15, 2021
bors bot pushed a commit that referenced this pull request Nov 16, 2021
…mooth (#10335)

Formalized as part of the Sphere Eversion project.
@bors
Copy link

bors bot commented Nov 16, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Nov 16, 2021
…mooth (#10335)

Formalized as part of the Sphere Eversion project.
@bors
Copy link

bors bot commented Nov 16, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/calculus/times_cont_diff): continuous affine maps are smooth [Merged by Bors] - feat(analysis/calculus/times_cont_diff): continuous affine maps are smooth Nov 16, 2021
@bors bors bot closed this Nov 16, 2021
@bors bors bot deleted the continous_affine_smooth branch November 16, 2021 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants