Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(analysis/mean_inequalities): split mean_inequalities into two files #10355

Closed
wants to merge 4 commits into from

Conversation

RemyDegenne
Copy link
Collaborator

This PR puts all results related to power functions into a new file.

Currently, we prove convexity of exp and pow, then use those properties in mean_inequalities. I am refactoring some parts of the analysis library to reduce the use of derivatives. I want to prove convexity of exp without derivatives (in a future PR), prove Holder's inequality, then use it to prove the convexity of pow. This requires Holder's inequality to be in a file that does not use convexity of pow, hence the split.

I needed to change the proof of Holder's inequality since it used the generalized mean inequality (hence pow). I switched to the second possible proof mentioned in the file docstring.

I also moved some lemmas in mean_inequalities to have three main sections: AM-GM, then Young and a final section with Holder and Minkowski.


The result of the whole refactor can be seen in the (stale) branch pow_split.

Open in Gitpod

@RemyDegenne RemyDegenne added the awaiting-CI The author would like to see what CI has to say before doing more work. label Nov 16, 2021
@RemyDegenne RemyDegenne added the awaiting-review The author would like community review of the PR label Nov 16, 2021
@RemyDegenne RemyDegenne changed the title chore(analysis/mean_inequalitites): split mean_inequalities into two files chore(analysis/mean_inequalities): split mean_inequalities into two files Nov 16, 2021
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Nov 16, 2021
@sgouezel
Copy link
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 17, 2021
bors bot pushed a commit that referenced this pull request Nov 17, 2021
…iles (#10355)

This PR puts all results related to power functions into a new file.

Currently, we prove convexity of `exp` and `pow`, then use those properties in `mean_inequalities`. I am refactoring some parts of the analysis library to reduce the use of derivatives. I want to prove convexity of exp without derivatives (in a future PR), prove Holder's inequality, then use it to prove the convexity of pow. This requires Holder's inequality to be in a file that does not use convexity of pow, hence the split.

I needed to change the proof of Holder's inequality since it used the generalized mean inequality (hence `pow`). I switched to the second possible proof mentioned in the file docstring.

I also moved some lemmas in `mean_inequalities` to have three main sections: AM-GM, then Young and a final section with Holder and Minkowski.
@bors
Copy link

bors bot commented Nov 17, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(analysis/mean_inequalities): split mean_inequalities into two files [Merged by Bors] - chore(analysis/mean_inequalities): split mean_inequalities into two files Nov 17, 2021
@bors bors bot closed this Nov 17, 2021
@bors bors bot deleted the mean_ineq_split branch November 17, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants