Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra/bilinear_map): semilinearize bilinear maps #10373

Closed
wants to merge 9 commits into from

Conversation

dupuisf
Copy link
Collaborator

@dupuisf dupuisf commented Nov 17, 2021

This PR generalizes most of linear_algebra/bilinear_map to semilinear maps. Along the way, we introduce an instance for module S (E →ₛₗ[σ] F), with σ : R →+* S. This allows us to define "semibilinear" maps of type E →ₛₗ[σ] F →ₛₗ[ρ] G, where E, F and G are modules over R₁, R₂ and R₃ respectively, and σ : R₁ →+* R₃ and ρ : R₂ →+* R₃. See mk₂'ₛₗ to see how to construct such a map.


Open in Gitpod

@dupuisf dupuisf added the awaiting-review The author would like community review of the PR label Nov 17, 2021
@dupuisf dupuisf added WIP Work in progress and removed awaiting-review The author would like community review of the PR labels Nov 18, 2021
dupuisf and others added 3 commits November 18, 2021 19:31
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@dupuisf dupuisf added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Nov 19, 2021
@dupuisf
Copy link
Collaborator Author

dupuisf commented Nov 19, 2021

By the way,

example (I : R →+* Rᵒᵖ) : M →ₗ[R] M →ₛₗ[I] R

typechecks, so this should be good enough to generalize sesq_form as well.

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

@hrmacbeth, look good to you?

@hrmacbeth
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 21, 2021
bors bot pushed a commit that referenced this pull request Nov 21, 2021
This PR generalizes most of `linear_algebra/bilinear_map` to semilinear maps. Along the way, we introduce an instance for `module S (E →ₛₗ[σ] F)`, with `σ : R →+* S`. This allows us to define "semibilinear" maps of type `E →ₛₗ[σ] F →ₛₗ[ρ] G`, where `E`, `F` and `G` are modules over `R₁`, `R₂` and `R₃` respectively, and `σ : R₁ →+* R₃` and `ρ : R₂ →+* R₃`. See `mk₂'ₛₗ` to see how to construct such a map.



Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@bors
Copy link

bors bot commented Nov 22, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/bilinear_map): semilinearize bilinear maps [Merged by Bors] - feat(linear_algebra/bilinear_map): semilinearize bilinear maps Nov 22, 2021
@bors bors bot closed this Nov 22, 2021
ocornoc pushed a commit that referenced this pull request Nov 22, 2021
This PR generalizes most of `linear_algebra/bilinear_map` to semilinear maps. Along the way, we introduce an instance for `module S (E →ₛₗ[σ] F)`, with `σ : R →+* S`. This allows us to define "semibilinear" maps of type `E →ₛₗ[σ] F →ₛₗ[ρ] G`, where `E`, `F` and `G` are modules over `R₁`, `R₂` and `R₃` respectively, and `σ : R₁ →+* R₃` and `ρ : R₂ →+* R₃`. See `mk₂'ₛₗ` to see how to construct such a map.



Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
ocornoc pushed a commit that referenced this pull request Nov 22, 2021
This PR generalizes most of `linear_algebra/bilinear_map` to semilinear maps. Along the way, we introduce an instance for `module S (E →ₛₗ[σ] F)`, with `σ : R →+* S`. This allows us to define "semibilinear" maps of type `E →ₛₗ[σ] F →ₛₗ[ρ] G`, where `E`, `F` and `G` are modules over `R₁`, `R₂` and `R₃` respectively, and `σ : R₁ →+* R₃` and `ρ : R₂ →+* R₃`. See `mk₂'ₛₗ` to see how to construct such a map.



Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
ericrbg pushed a commit that referenced this pull request Nov 24, 2021
This PR generalizes most of `linear_algebra/bilinear_map` to semilinear maps. Along the way, we introduce an instance for `module S (E →ₛₗ[σ] F)`, with `σ : R →+* S`. This allows us to define "semibilinear" maps of type `E →ₛₗ[σ] F →ₛₗ[ρ] G`, where `E`, `F` and `G` are modules over `R₁`, `R₂` and `R₃` respectively, and `σ : R₁ →+* R₃` and `ρ : R₂ →+* R₃`. See `mk₂'ₛₗ` to see how to construct such a map.



Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants