Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(measure_theory/integral): generalize integral_smul_const #10411

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - chore(measure_theory/integral): generalize integral_smul_const #10411

wants to merge 9 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Nov 21, 2021 •
edited by github-actions bot

  • generalize to is_R_or_C;
  • add an interval_integral version.

Open in Gitpod

@urkud
feat(measure_theory/integral/interval_integral): add an alternative d…
8fec3c8 
…efinition

Prove that `∫ x in a..b, f x ∂μ = sgn a b • ∫ x in Ι a b, f x ∂μ`,
where `sgn a b = if a ≤ b then 1 else -1`.
@urkud
Apply suggestions from code review
cf3576b
@urkud
Golf
8dc70f9
@urkud
chore(measure_theory/integral): generalize integral_smul_const
af5e95a 
* generalize to `is_R_or_C`;
* add an `interval_integral` version.
@urkud urkud added the awaiting-review The author would like community review of the PR label Nov 21, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Nov 21, 2021
@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Nov 23, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

jcommelin
jcommelin approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 23, 2021
bors bot pushed a commit that referenced this pull request Nov 23, 2021
@urkud
chore(measure_theory/integral): generalize integral_smul_const (#10411
c7c4a64 
)

* generalize to `is_R_or_C`;
* add an `interval_integral` version.
@bors
Copy link

bors bot commented Nov 23, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Nov 23, 2021
@urkud
chore(measure_theory/integral): generalize integral_smul_const (#10411
ac71292 
)

* generalize to `is_R_or_C`;
* add an `interval_integral` version.
@bors
Copy link

bors bot commented Nov 23, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(measure_theory/integral): generalize integral_smul_const [Merged by Bors] - chore(measure_theory/integral): generalize integral_smul_const Nov 23, 2021
@bors bors bot closed this Nov 23, 2021
@bors bors bot deleted the YK-integral-smul-const branch November 23, 2021 10:36
ericrbg pushed a commit that referenced this pull request Nov 24, 2021
@urkud @ericrbg
chore(measure_theory/integral): generalize integral_smul_const (#10411
d177b5e 
)

* generalize to `is_R_or_C`;
* add an `interval_integral` version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @jcommelin