Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(category_theory): Glue data #10436

Closed
wants to merge 11 commits into from
Closed

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Nov 23, 2021


Open in Gitpod

@erdOne erdOne added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR labels Nov 23, 2021
@erdOne erdOne added this to In progress in Algebraic geometry via automation Nov 23, 2021
@erdOne erdOne removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Nov 23, 2021
@erdOne erdOne moved this from In progress to Pending review in Algebraic geometry Nov 23, 2021
src/category_theory/glue_data.lean Outdated Show resolved Hide resolved
/-!
# Gluing data

We define `glue_data` as a family of data needed to glue topological spaces, schemes, etc. We
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the vague feeling that this should instead be rephrased using coverings in a Grothendieck topology? Does that make sense? I haven't thought hard about this.
Instead of gluing objects in a glue_data, isn't the more general theorem something like: if a sheaf for a suitable topology is locally representable, then it is globally representable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing is that we do not have the glued space to take cover of in most of my use cases.
The statement you mentioned seems to me to be closer to the comparison lemma (we can glue sheaves on a cover that is somehow dense enough).

src/category_theory/glue_data.lean Outdated Show resolved Hide resolved
src/category_theory/glue_data.lean Outdated Show resolved Hide resolved
src/category_theory/glue_data.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Nov 24, 2021
@erdOne erdOne added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 24, 2021
src/category_theory/glue_data.lean Outdated Show resolved Hide resolved
src/category_theory/glue_data.lean Outdated Show resolved Hide resolved
src/category_theory/glue_data.lean Outdated Show resolved Hide resolved
src/category_theory/glue_data.lean Show resolved Hide resolved
src/category_theory/glue_data.lean Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Nov 30, 2021
erdOne and others added 3 commits November 30, 2021 16:45
@erdOne erdOne added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 30, 2021
Copy link
Collaborator

@adamtopaz adamtopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks perfectly fine to me. I do have some doubts about the design choices... Perhaps it would be easier to discuss this on zulip?

src/category_theory/glue_data.lean Outdated Show resolved Hide resolved
(U : J → C)
(V : J × J → C)
(f : Π i j, V (i, j) ⟶ U i)
(f_mono : ∀ i j, mono (f i j) . tactic.apply_instance)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little unsure about this mono assumption. If I understand correctly, we will eventually want to apply this to the case of topological spaces and/or schemes, where these morphisms f i j are open immersions. But in general there are monomorphisms in these categories that need not be open immersions. What does this mono assumption give you at this level of generality? Does it make sense to relax this assumption for the purposes of this file?

Co-authored-by: Adam Topaz <adamtopaz@users.noreply.github.com>
@jcommelin
Copy link
Member

jcommelin commented Dec 18, 2021

Let's just move forward with this PR. If it turns out we need to tweak it, we can refactor later. It's holding up cool stuff.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 18, 2021
bors bot pushed a commit that referenced this pull request Dec 18, 2021


Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@bors
Copy link

bors bot commented Dec 18, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory): Glue data [Merged by Bors] - feat(category_theory): Glue data Dec 18, 2021
@bors bors bot closed this Dec 18, 2021
Algebraic geometry automation moved this from Pending review to Done Dec 18, 2021
@bors bors bot deleted the glue_data branch December 18, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants