Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/lie): implement set_like for lie_submodule #10488

Closed
wants to merge 2 commits into from

Conversation

Vierkantor
Copy link
Collaborator

This PR provides a set_like instance for lie_submodule and uses it to define has_mem and has_le for Lie submodules / ideals.


Open in Gitpod

@Vierkantor Vierkantor added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Nov 25, 2021
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Nov 25, 2021
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace the implementation of ext with set_like.ext too?

bors d+

@bors
Copy link

bors bot commented Nov 26, 2021

✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Nov 26, 2021
@Vierkantor
Copy link
Collaborator Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Nov 26, 2021
bors bot pushed a commit that referenced this pull request Nov 26, 2021
This PR provides a `set_like` instance for `lie_submodule` and uses it to define `has_mem` and `has_le` for Lie submodules / ideals.
@bors
Copy link

bors bot commented Nov 26, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/lie): implement set_like for lie_submodule [Merged by Bors] - feat(algebra/lie): implement set_like for lie_submodule Nov 26, 2021
@bors bors bot closed this Nov 26, 2021
@bors bors bot deleted the lie_submodule-set_like branch November 26, 2021 16:19
ericrbg pushed a commit that referenced this pull request Nov 27, 2021
This PR provides a `set_like` instance for `lie_submodule` and uses it to define `has_mem` and `has_le` for Lie submodules / ideals.
jcommelin pushed a commit that referenced this pull request Dec 18, 2021
This PR provides a `set_like` instance for `lie_submodule` and uses it to define `has_mem` and `has_le` for Lie submodules / ideals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-for-bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants