Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebraic_geometry): Generalized basic open for arbitrary sections #10515

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(algebraic_geometry): Generalized basic open for arbitrary sections #10515

wants to merge 3 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Nov 27, 2021

Open in Gitpod

@erdOne erdOne added this to In progress in Algebraic geometry via automation Nov 27, 2021
@erdOne erdOne moved this from In progress to Pending review in Algebraic geometry Nov 27, 2021
@erdOne erdOne assigned erdOne and unassigned erdOne Nov 27, 2021
@erdOne erdOne added the awaiting-review The author would like community review of the PR label Nov 27, 2021
jcommelin
jcommelin approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 30, 2021
bors bot pushed a commit that referenced this pull request Nov 30, 2021
@erdOne
feat(algebraic_geometry): Generalized basic open for arbitrary sectio…
1077f34 
…ns (#10515)
@bors
Copy link

bors bot commented Nov 30, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebraic_geometry): Generalized basic open for arbitrary sections [Merged by Bors] - feat(algebraic_geometry): Generalized basic open for arbitrary sections Nov 30, 2021
@bors bors bot closed this Nov 30, 2021
Algebraic geometry automation moved this from Pending review to Done Nov 30, 2021
@bors bors bot deleted the ringed_space_basic_open branch November 30, 2021 12:26
jcommelin pushed a commit that referenced this pull request Dec 18, 2021
@erdOne @jcommelin
feat(algebraic_geometry): Generalized basic open for arbitrary sectio…
6f229bf 
…ns (#10515)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
Algebraic geometry
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erdOne @jcommelin