Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(logic): allow Sort* args in 2 lemmas #10517

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(logic): allow Sort* args in 2 lemmas #10517

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Nov 27, 2021 •
edited by ericrbg

@urkud urkud added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Nov 27, 2021
@urkud urkud mentioned this pull request Nov 27, 2021
Closed
1 task
@robertylewis
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 27, 2021
bors bot pushed a commit that referenced this pull request Nov 27, 2021
@urkud
chore(logic): allow Sort* args in 2 lemmas (#10517)
97d51b6
@bors
Copy link

bors bot commented Nov 27, 2021

Build failed:

@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Nov 28, 2021
@github-actions github-actions bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Nov 28, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@ericrbg ericrbg added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 28, 2021
@urkud urkud added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Nov 28, 2021
@urkud
Copy link
Member Author

urkud commented Nov 28, 2021

It was on the queue, so I assume that it's delegated. I'll merge it once CI is happy.

@urkud
Copy link
Member Author

urkud commented Nov 28, 2021

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Nov 28, 2021
bors bot pushed a commit that referenced this pull request Nov 28, 2021
@urkud
chore(logic): allow Sort* args in 2 lemmas (#10517)
77ba0c4
@bors
Copy link

bors bot commented Nov 29, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(logic): allow Sort* args in 2 lemmas [Merged by Bors] - chore(logic): allow Sort* args in 2 lemmas Nov 29, 2021
@bors bors bot closed this Nov 29, 2021
@bors bors bot deleted the YK-Sort branch November 29, 2021 01:36
jcommelin pushed a commit that referenced this pull request Dec 18, 2021
@urkud @jcommelin
chore(logic): allow Sort* args in 2 lemmas (#10517)
5a26d2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @robertylewis @bryangingechen @ericrbg