Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(category_theory/sites/*): Adjust some simp lemmas. #10574

Closed
wants to merge 36 commits into from

Conversation

adamtopaz
Copy link
Collaborator

@adamtopaz adamtopaz commented Dec 2, 2021

The primary change is removing some simp tags from the definition of sheafify and friends, so that the sheafification related constructions are not unfolded to the plus constructions.

Also -- added coercion from Sheaves to presheaves, and some rfl simp lemmas which help some proofs move along.

Some proofs cleaned up as well.


Open in Gitpod

@adamtopaz adamtopaz added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR labels Dec 2, 2021
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed awaiting-CI The author would like to see what CI has to say before doing more work. labels Dec 2, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 2, 2021
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 2, 2021
bors bot pushed a commit that referenced this pull request Dec 2, 2021
The primary change is removing some `simp` tags from the definition of `sheafify` and friends, so that the sheafification related constructions are not unfolded to the `plus` constructions.

Also -- added coercion from Sheaves to presheaves, and some `rfl` simp lemmas which help some proofs move along.

Some proofs cleaned up as well.



Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Dec 2, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Dec 2, 2021
The primary change is removing some `simp` tags from the definition of `sheafify` and friends, so that the sheafification related constructions are not unfolded to the `plus` constructions.

Also -- added coercion from Sheaves to presheaves, and some `rfl` simp lemmas which help some proofs move along.

Some proofs cleaned up as well.



Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Dec 2, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(category_theory/sites/*): Adjust some simp lemmas. [Merged by Bors] - chore(category_theory/sites/*): Adjust some simp lemmas. Dec 2, 2021
@bors bors bot closed this Dec 2, 2021
@bors bors bot deleted the some_cleanup_of_sheaves branch December 2, 2021 20:44
jcommelin added a commit that referenced this pull request Dec 18, 2021
The primary change is removing some `simp` tags from the definition of `sheafify` and friends, so that the sheafification related constructions are not unfolded to the `plus` constructions.

Also -- added coercion from Sheaves to presheaves, and some `rfl` simp lemmas which help some proofs move along.

Some proofs cleaned up as well.



Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants