Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category_theory/limits): The product is the pullback over the terminal objects. #10581

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(category_theory/limits): The product is the pullback over the terminal objects. #10581

wants to merge 1 commit into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Dec 2, 2021

Open in Gitpod

@erdOne erdOne added the awaiting-review The author would like community review of the PR label Dec 2, 2021
@erdOne erdOne added this to Pending review in Algebraic geometry Dec 2, 2021
jcommelin
jcommelin approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 3, 2021
bors bot pushed a commit that referenced this pull request Dec 3, 2021
@erdOne
feat(category_theory/limits): The product is the pullback over the te…
0453320 
…rminal objects. (#10581)
@bors
Copy link

bors bot commented Dec 3, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/limits): The product is the pullback over the terminal objects. [Merged by Bors] - feat(category_theory/limits): The product is the pullback over the terminal objects. Dec 3, 2021
@bors bors bot closed this Dec 3, 2021
Algebraic geometry automation moved this from Pending review to Done Dec 3, 2021
@bors bors bot deleted the product_pullback branch December 3, 2021 10:54
jcommelin pushed a commit that referenced this pull request Dec 18, 2021
@erdOne @jcommelin
feat(category_theory/limits): The product is the pullback over the te…
bc77e02 
…rminal objects. (#10581)
This was referenced May 23, 2022
Closed
Closed
bors bot pushed a commit that referenced this pull request Jun 13, 2022
@semorrison
feat(category_theory/limits): realise products as pullbacks (#14322)
b44e742 
This was mostly done in #10581, this just adds the isomorphisms between the objects produced by the `has_limit` API.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
Algebraic geometry
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erdOne @jcommelin