Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(algebra/module): generalize char_zero.of_algebra to char_zero.of_module #10609

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - chore(algebra/module): generalize char_zero.of_algebra to char_zero.of_module #10609

wants to merge 3 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 4, 2021

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Dec 4, 2021
urkud
urkud commented Dec 4, 2021
View reviewed changes
src/algebra/module/basic.lean Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Dec 4, 2021
@RemyDegenne
Copy link
Collaborator

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 4, 2021
bors bot pushed a commit that referenced this pull request Dec 4, 2021
@urkud
chore(alegbra/module): generalize char_zero.of_algebra to `char_zer…
4ff4d1a 
…o.of_module` (#10609)
@eric-wieser eric-wieser changed the title chore(alegbra/module): generalize char_zero.of_algebra to char_zero.of_module chore(algebra/module): generalize char_zero.of_algebra to char_zero.of_module Dec 4, 2021
@eric-wieser
Copy link
Member

eric-wieser commented Dec 4, 2021 •
edited

bors r-

Nothing else was on the queue, so I figured I'd cancel it to correct the typo in the commit message.

@bors
Copy link

bors bot commented Dec 4, 2021

Canceled.

@eric-wieser
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Dec 4, 2021

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Dec 4, 2021
@urkud @eric-wieser
Apply suggestions from code review
d065f26 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@urkud
Copy link
Member Author

urkud commented Dec 4, 2021

bors merge

bors bot pushed a commit that referenced this pull request Dec 4, 2021
@urkud
chore(algebra/module): generalize char_zero.of_algebra to `char_zer…
b3b7fe6 
…o.of_module` (#10609)
@bors
Copy link

bors bot commented Dec 4, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/module): generalize char_zero.of_algebra to char_zero.of_module [Merged by Bors] - chore(algebra/module): generalize char_zero.of_algebra to char_zero.of_module Dec 4, 2021
@bors bors bot closed this Dec 4, 2021
@bors bors bot deleted the YK-module-char branch December 4, 2021 15:24
jcommelin pushed a commit that referenced this pull request Dec 18, 2021
@urkud @jcommelin
chore(algebra/module): generalize char_zero.of_algebra to `char_zer…
2a59dff 
…o.of_module` (#10609)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @RemyDegenne @eric-wieser