[Merged by Bors] - chore(tactic/reserved_notation): change precedence of sup and inf #10623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemyDegenne
added
the
awaiting-review
eric-wieser
reviewed
Dec 5, 2021
eric-wieser
reviewed
Dec 5, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Feel free to experiment with other values. I won't spend time on this. If you want to try 71 and 72 I can put this PR on hold until we decide what values we want. |
|
Let's merge this for now. If someone wants to revisit this later, this will still be possible, but this is already a net improvement over what we have currently. |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Dec 12, 2021
…0623) Put the precedence of `⊔` and `⊓` at 68 and 69 respectively, which is above `+` (65), `∑` and `∏` (67), and below `*` (70). This makes sure that inf and sup behave in the same way in expressions where arithmetic operations appear (which was not the case before). Discussion: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/inf.20and.20sup.20don't.20bind.20similarly Co-authored-by: Rémy Degenne <remydegenne@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put the precedence of
⊔and⊓at 68 and 69 respectively, which is above+(65),∑and∏(67), and below*(70). This makes sure that inf and sup behave in the same way in expressions where arithmetic operations appear (which was not the case before).Discussion: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/inf.20and.20sup.20don't.20bind.20similarly