Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(order/zorn): Added some results about chains #10658

Closed
wants to merge 13 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Dec 7, 2021

Added chain_empty, chain_subsingleton, and chain.max_chain_of_chain.

The first two of these are immediate yet useful lemmas. The last one is a consequence of Zorn's lemma, which generalizes Hausdorff's maximality principle.


Open in Gitpod

@vihdzp vihdzp added the awaiting-review The author would like community review of the PR label Dec 7, 2021
@vihdzp vihdzp changed the title Added some results about chains feat(order/zorn): Added some results about chains Dec 7, 2021
src/order/zorn.lean Outdated Show resolved Hide resolved
src/order/zorn.lean Outdated Show resolved Hide resolved
src/order/zorn.lean Outdated Show resolved Hide resolved
src/order/zorn.lean Outdated Show resolved Hide resolved
vihdzp and others added 4 commits December 7, 2021 18:50
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
src/order/zorn.lean Outdated Show resolved Hide resolved
src/order/zorn.lean Outdated Show resolved Hide resolved
vihdzp and others added 2 commits December 9, 2021 15:01
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your variable names are a bit confusing but that's just style.

src/order/zorn.lean Outdated Show resolved Hide resolved
src/order/zorn.lean Outdated Show resolved Hide resolved
src/order/zorn.lean Outdated Show resolved Hide resolved
vihdzp and others added 3 commits December 12, 2021 14:04
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@fpvandoorn
Copy link
Member

LGTM. Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 15, 2021
bors bot pushed a commit that referenced this pull request Dec 15, 2021
Added `chain_empty`, `chain_subsingleton`, and `chain.max_chain_of_chain`.

The first two of these are immediate yet useful lemmas. The last one is a consequence of Zorn's lemma, which generalizes Hausdorff's maximality principle.
@bors
Copy link

bors bot commented Dec 15, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Dec 15, 2021
Added `chain_empty`, `chain_subsingleton`, and `chain.max_chain_of_chain`.

The first two of these are immediate yet useful lemmas. The last one is a consequence of Zorn's lemma, which generalizes Hausdorff's maximality principle.
@bors
Copy link

bors bot commented Dec 15, 2021

Build failed (retrying...):

@gebner
Copy link
Member

gebner commented Dec 15, 2021

bors r-

@bors
Copy link

bors bot commented Dec 15, 2021

Canceled.

@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Dec 15, 2021
@bryangingechen
Copy link
Collaborator

Please merge master, fix any breakages, and put this back on the queue. Thanks!
bors d+

@bors
Copy link

bors bot commented Dec 15, 2021

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Dec 15, 2021
@YaelDillies
Copy link
Collaborator

Sorry this is the change to implicitness arguments to set.pairwise. Let me fix it quickly.

@vihdzp
Copy link
Collaborator Author

vihdzp commented Dec 15, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 15, 2021
Added `chain_empty`, `chain_subsingleton`, and `chain.max_chain_of_chain`.

The first two of these are immediate yet useful lemmas. The last one is a consequence of Zorn's lemma, which generalizes Hausdorff's maximality principle. 



Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
@bors
Copy link

bors bot commented Dec 15, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/zorn): Added some results about chains [Merged by Bors] - feat(order/zorn): Added some results about chains Dec 15, 2021
@bors bors bot closed this Dec 15, 2021
@bors bors bot deleted the chain_lemmas branch December 15, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants