[Merged by Bors] - feat(*): Random lemmas about adjoin/span. #10666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdOne
added
awaiting-CI
github-actions
bot
removed
the
awaiting-CI
urkud
reviewed
Dec 9, 2021
urkud
reviewed
Dec 9, 2021
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
…ty/mathlib into adjoin_lemmas
erdOne
commented
Dec 9, 2021
| change x ∈ (adjoin R s).to_submodule at hx, | ||
| rw [adjoin_eq_span, finsupp.mem_span_iff_total] at hx, | ||
| rcases hx with ⟨l, rfl : l.sum (λ (i : submonoid.closure s) (c : R), c • ↑i) = x⟩, | ||
| choose n₁ n₂ using (λ x : submonoid.closure s, submonoid.pow_smul_mem_closure_smul r s x.prop), |
There was a problem hiding this comment.
Is there a better way of achieving the same thing now that the signature of
submonoid.pow_smul_mem_closure_smul is changed?
jcommelin
reviewed
Dec 13, 2021
jcommelin
added
awaiting-author
Co-authored-by: Johan Commelin <johan@commelin.net>
erdOne
added
awaiting-review
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Dec 13, 2021
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paving my way to showing that being finite / of finite type is a local property