Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(group_theory/quotient_group): use con #10699

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - refactor(group_theory/quotient_group): use con #10699

wants to merge 2 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 10, 2021

Use con to define group structure on G ⧸ N instead of repeating the construction in this case.

Open in Gitpod

@urkud urkud added the awaiting-review The author would like community review of the PR label Dec 10, 2021
jcommelin
jcommelin approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 10, 2021
eric-wieser
eric-wieser approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

bors bot pushed a commit that referenced this pull request Dec 10, 2021
@urkud
refactor(group_theory/quotient_group): use con (#10699)
4ac6ad8 
Use `con` to define `group` structure on `G ⧸ N` instead of repeating the construction in this case.
@bors
Copy link

bors bot commented Dec 10, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Dec 10, 2021
@urkud
refactor(group_theory/quotient_group): use con (#10699)
165e055 
Use `con` to define `group` structure on `G ⧸ N` instead of repeating the construction in this case.
@bors
Copy link

bors bot commented Dec 10, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(group_theory/quotient_group): use con [Merged by Bors] - refactor(group_theory/quotient_group): use con Dec 10, 2021
@bors bors bot closed this Dec 10, 2021
@bors bors bot deleted the YK-qgrp-con branch December 10, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @eric-wieser @jcommelin