Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data/nat/prime): add the subtype of prime numbers #1071

Closed
wants to merge 2 commits into from

Conversation

jcommelin
Copy link
Member

Inspired by the perfectoid project.

@jcommelin jcommelin requested a review from a team as a code owner May 21, 2019 08:57
@semorrison
Copy link
Collaborator

Nothing more to say about these? This might be slicing the salami a little thin. :-)

@digama0
Copy link
Member

digama0 commented May 21, 2019

Why not define a set instead, and use set_coe?

@jcommelin
Copy link
Member Author

Nope, we don't do anything with prime numbers. They only show up in the top-level file of the project...
We could just leave this definition in the project... I don't really care.

@NeilStrickland
Copy link
Contributor

I have also added this type in #1073 (which contains lots of other things). I called it nat.primes. I think that it is probably better to have it in the nat namespace. Beyond that, I am not sure what is the best naming convention. Perhaps we should rename nat.prime to nat.is_prime and then the type can be called nat.prime.

@jcommelin jcommelin closed this May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants